From derby-commits-return-1197-apmail-db-derby-commits-archive=db.apache.org@db.apache.org Thu Aug 04 14:20:46 2005 Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 11974 invoked from network); 4 Aug 2005 14:20:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Aug 2005 14:20:45 -0000 Received: (qmail 90733 invoked by uid 500); 4 Aug 2005 14:20:45 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 90685 invoked by uid 500); 4 Aug 2005 14:20:44 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 90671 invoked by uid 99); 4 Aug 2005 14:20:43 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 04 Aug 2005 07:20:30 -0700 Received: (qmail 11911 invoked by uid 65534); 4 Aug 2005 14:20:28 -0000 Message-ID: <20050804142028.11909.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r227406 - /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java Date: Thu, 04 Aug 2005 14:20:27 -0000 To: derby-commits@db.apache.org From: djd@apache.org X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: djd Date: Thu Aug 4 07:20:25 2005 New Revision: 227406 URL: http://svn.apache.org/viewcvs?rev=227406&view=rev Log: DERBY-488 Cast the return (DataValueDescriptor) from a generated call to setWidth to the type of the field it was being stored in (sub-class of DataValueDescriptor, e.g. NumberDataValue). The previous incorrect assignment worked and passed most verifiers but the 1.4.2 VM on IBM iSeries rejected the generated class. Modified: db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java Modified: db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java URL: http://svn.apache.org/viewcvs/db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java?rev=227406&r1=227405&r2=227406&view=diff ============================================================================== --- db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java (original) +++ db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java Thu Aug 4 07:20:25 2005 @@ -600,6 +600,7 @@ mb.push(getTypeServices().getScale()); mb.push(true); mb.callMethod(VMOpcode.INVOKEINTERFACE, ClassName.VariableSizeDataValue, "setWidth", ClassName.DataValueDescriptor, 3); + mb.cast(resultTypeName); } }