Return-Path: Delivered-To: apmail-db-ddlutils-dev-archive@www.apache.org Received: (qmail 51188 invoked from network); 3 Jan 2006 20:04:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Jan 2006 20:04:17 -0000 Received: (qmail 84289 invoked by uid 500); 3 Jan 2006 20:04:16 -0000 Delivered-To: apmail-db-ddlutils-dev-archive@db.apache.org Received: (qmail 84270 invoked by uid 500); 3 Jan 2006 20:04:16 -0000 Mailing-List: contact ddlutils-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ddlutils-dev@db.apache.org Delivered-To: mailing list ddlutils-dev@db.apache.org Received: (qmail 84259 invoked by uid 99); 3 Jan 2006 20:04:16 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2006 12:04:16 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of tomdzk@gmail.com designates 64.233.182.196 as permitted sender) Received: from [64.233.182.196] (HELO nproxy.gmail.com) (64.233.182.196) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2006 12:04:15 -0800 Received: by nproxy.gmail.com with SMTP id l36so998908nfa for ; Tue, 03 Jan 2006 12:03:54 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=p0Spbt/RuSWgBz3+RTzJaveCK+6o5BIj+RAla+Mp5TMEB9mt9wJcZN4KwidowL3EVVvtaBpPde162JNuge+3VImozd0AR+SGKysdPponTm6l9K7Q3gomI5AKUA9TiEPMzxaeaoPbjovIRxGuq89iRu7hxIgJQFg59CdJ+SZ0Mg8= Received: by 10.48.244.20 with SMTP id r20mr606321nfh; Tue, 03 Jan 2006 12:03:54 -0800 (PST) Received: by 10.48.250.15 with HTTP; Tue, 3 Jan 2006 12:03:54 -0800 (PST) Message-ID: <224f32340601031203g29baf52egcd8dfa5539c96117@mail.gmail.com> Date: Tue, 3 Jan 2006 21:03:54 +0100 From: Thomas Dudziak To: ddlutils-dev@db.apache.org Subject: Re: svn commit: r365722 - /db/ddlutils/trunk/src/test/org/apache/ddlutils/io/ConstraintsTestBase.java In-Reply-To: <20060103195302.45696.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060103195302.45696.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 1/3/06, mvdb@apache.org wrote: > Make test fail when the platform doesn't match. Else we have a bogus pass= ing test. Please don't do that! Before this change, I could simply run all tests in src/test package (e.g. in Eclipse "run all tests in package") regardless of which database I run against. This is no longer possible if the wrong platform fails the test. Btw, I have some ideas to make this a lot nicer using parameterized tests (so that we do not need the test cases per platform anymore), but I won't have time for it before the weekend. regards, Tom