From ddlutils-dev-return-428-apmail-db-ddlutils-dev-archive=db.apache.org@db.apache.org Thu Dec 22 23:16:41 2005 Return-Path: Delivered-To: apmail-db-ddlutils-dev-archive@www.apache.org Received: (qmail 97592 invoked from network); 22 Dec 2005 23:16:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Dec 2005 23:16:40 -0000 Received: (qmail 60398 invoked by uid 500); 22 Dec 2005 23:16:40 -0000 Delivered-To: apmail-db-ddlutils-dev-archive@db.apache.org Received: (qmail 60365 invoked by uid 500); 22 Dec 2005 23:16:40 -0000 Mailing-List: contact ddlutils-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ddlutils-dev@db.apache.org Delivered-To: mailing list ddlutils-dev@db.apache.org Received: (qmail 60349 invoked by uid 99); 22 Dec 2005 23:16:39 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2005 15:16:39 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [69.55.235.171] (HELO mvdb.net) (69.55.235.171) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 22 Dec 2005 15:16:39 -0800 Received: (qmail 7840 invoked from network); 22 Dec 2005 23:16:15 -0000 Received: from unknown (HELO [10.21.21.40]) (80.126.215.98) by 69.55.235.171 with SMTP; Thu, 22 Dec 2005 23:16:15 +0000 Message-ID: <43AB33C7.1070405@mvdb.net> Date: Fri, 23 Dec 2005 00:16:23 +0100 From: Martin van den Bemt User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: ddlutils-dev@db.apache.org Subject: Re: Failing tests testColumnConstraints + location integration / roundtrip tests References: <43AB0EB4.7030208@mvdb.net> <224f32340512221246w4e47b1ddp7f7ed514552b2269@mail.gmail.com> <43AB19FB.2070202@mvdb.net> <224f32340512221334va15dae2j252e256a4818050e@mail.gmail.com> In-Reply-To: <224f32340512221334va15dae2j252e256a4818050e@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thomas Dudziak wrote: > On 12/22/05, Martin van den Bemt wrote: > > >>Ah ok.. You are in Germany right ? > > Yes, in Berlin. I am in Breda, in the south of The Netherlands. In short : not a driving distance :) > > >>I think the io test package will actually mix too many concerns if we do that, since most classes in io can be unit tested (integration tests have nothing to do with io unit tests). So at least we should consider a new package name, with probably subpackages like derby, axion, hsqldb, oracle, since I don't think we'll going to end up with 1 testcase per database and things (in my opinion) will get quite messy otherwise. > > > Why do you think that is necessary? If you look into class > RoundtripTestBase, you'll see what I intend to test. Most if not all > of these will look like the tests already in TestRoundtripDerby, > though I expect I can refactor the tests later on to make them even > shorter. When I look at the TestRoundTripDerby and the RoundTripTestBase, I cannot see anything specific that you are just targetting the io package, unless you mean the part where you use the DataReader. That testcoverage that is achieved in the io package is merely a side effect of these integration tests. Probably unit testing DataReader needs some mocks to keep it a unit test (same as eg platform.* should have some mocks, where eg a connection is needed (like in fetch). In my opinion we should treat any class that we feed a realtime database connection as an integration test and move them to a different package and in my preference source tree. Just to be clear TestDatabaseIO and TestDataReader are of course in the right place. > Do you plan to add other tests (right now, the roundtrip test do: > create, insert data, fetch data, read model from db and check it) ? Not specifically, but to maintain readability of classes (esp when testcases get big), I tend to create separate testcases. Subpackaging is not needed right away, we can do that when there is a need to. > One thing that has to be added yet is testing without delimiters. Axion doesn't like delimiters :) > >>About Axion : roundtripping will not work that well (working on axion currently), since I get some not supported exceptions when importing the model from the database itself. > > > Mhmm, not good, but not DdlUtils fault either. When we document that > properly, this should be no problem ? Indeed and just noticed (to my surprise) there is actually some development going on axion, so who knows some things get fixed.. (i'll see if I can file an issue for the lack of support on getImportKeys) Mvgr, Martin