From dev-return-2381-archive-asf-public=cust-asf.ponee.io@datafu.apache.org Mon Aug 19 20:36:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 720E518067E for ; Mon, 19 Aug 2019 22:36:02 +0200 (CEST) Received: (qmail 11973 invoked by uid 500); 19 Aug 2019 20:36:01 -0000 Mailing-List: contact dev-help@datafu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.apache.org Delivered-To: mailing list dev@datafu.apache.org Received: (qmail 11870 invoked by uid 99); 19 Aug 2019 20:36:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Aug 2019 20:36:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9E05E300B for ; Mon, 19 Aug 2019 20:36:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 32234782234 for ; Mon, 19 Aug 2019 20:36:00 +0000 (UTC) Date: Mon, 19 Aug 2019 20:36:00 +0000 (UTC) From: "Matthew Hayes (Jira)" To: dev@datafu.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DATAFU-128) Add documentation for macros MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DATAFU-128?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1691= 0737#comment-16910737 ]=20 Matthew Hayes commented on DATAFU-128: -------------------------------------- Thanks Eyal!=C2=A0 This looks good so far.=C2=A0 Below are some comments.= =C2=A0 By the way I think you could open a RB now.=C2=A0 Supposedly it was = fixed. *README.md* * typo:=C2=A0modules's *site/source/index.markdown.erb* * Missing asterisk after DataFu Spark *General comments* I think the getting started page for Spark should mention something about h= ow make Spark use the downloaded JAR.=C2=A0 The example assumes you already= know how to do this.=C2=A0 Also the Spark Guide is pretty short.=C2=A0 I'm= assuming you probably intend to write more there :) > Add documentation for macros > ---------------------------- > > Key: DATAFU-128 > URL: https://issues.apache.org/jira/browse/DATAFU-128 > Project: DataFu > Issue Type: Improvement > Reporter: Eyal Allweil > Assignee: Eyal Allweil > Priority: Major > Attachments: DATAFU-128.patch > > > Now that it is possible to [add Pig macros to Datafu|https://issues.apach= e.org/jira/browse/DATAFU-123], we should update the documentation to reflec= t this, and provide guidelines and point would-be contributors to examples. -- This message was sent by Atlassian Jira (v8.3.2#803003)