datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [datafu] eyala commented on a change in pull request #15: Add Spark functionality to DataFu, datafu-spark
Date Thu, 30 May 2019 14:02:55 GMT
eyala commented on a change in pull request #15: Add Spark functionality to DataFu, datafu-spark
URL: https://github.com/apache/datafu/pull/15#discussion_r289003198
 
 

 ##########
 File path: datafu-spark/build_and_test_spark.sh
 ##########
 @@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#!/bin/bash
+
+export SPARKS_210="2.1.0 2.1.1 2.1.2 2.1.3 2.2.0 2.2.1 2.2.2"
 
 Review comment:
   Agreed - I changed the variable names - I think they're self-explanatory now (SPARK_VERSIONS_FOR_SCALA_210,
etc).
   
   As for Scala support - I checked that the tests run locally for Scala 2.10 and 2.11, and
on a cluster with 2.11. That's why we have all the different pyspark and py4j versions, things
were failing without the appropriate version being chosen in the tests.
   
   But on a cluster, it should work with whatever has been installed. The relevant code is
[here.](https://github.com/apache/datafu/blob/spark-tmp/datafu-spark/src/main/scala/datafu/spark/ScalaPythonBridge.scala#L42)
@uzadude can probably explain this better than me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message