datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthew Hayes <matthew.terence.ha...@gmail.com>
Subject Re: Review Request 63320: DATAFU-131 added links to meet graduation requirements
Date Tue, 28 Nov 2017 02:28:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63320/#review191990
-----------------------------------------------------------


Fix it, then Ship it!




This mostly looks good to me.


site/source/layouts/_footer.erb
Line 21 (original), 21 (patched)
<https://reviews.apache.org/r/63320/#comment269990>

    Centering the text like this with the feather in the middle looks a bit weird to me. 
I looked at another podling as an example. The  [http://slider.incubator.apache.org/](Slider
website) has the feather floated to the left of the text, which I think looks better.


- Matthew Hayes


On Oct. 26, 2017, 3:01 a.m., Yuval Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63320/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2017, 3:01 a.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> Added required links and logo
> 
> 
> Diffs
> -----
> 
>   site/source/images/feather.png PRE-CREATION 
>   site/source/index.markdown.erb fdbc8c0 
>   site/source/layouts/_docs_nav.erb 9ded15e 
>   site/source/layouts/_footer.erb 9e074d1 
> 
> 
> Diff: https://reviews.apache.org/r/63320/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Yuval Allweil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message