Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3521200CAD for ; Wed, 28 Jun 2017 16:52:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C1B9F160BF7; Wed, 28 Jun 2017 14:52:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 12653160BE8 for ; Wed, 28 Jun 2017 16:52:24 +0200 (CEST) Received: (qmail 38158 invoked by uid 500); 28 Jun 2017 14:52:24 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 38135 invoked by uid 99); 28 Jun 2017 14:52:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 14:52:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C852FCCE82; Wed, 28 Jun 2017 14:52:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.99 X-Spam-Level: ** X-Spam-Status: No, score=2.99 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XKzs5mjSc163; Wed, 28 Jun 2017 14:52:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A4CED5FB62; Wed, 28 Jun 2017 14:52:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 07880E0026; Wed, 28 Jun 2017 14:52:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EE555C40062; Wed, 28 Jun 2017 14:52:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1830204357632680201==" MIME-Version: 1.0 Subject: Re: Review Request 60396: DATAFU-124 sessionize() ought to support millisecond periods From: Eyal Allweil via Review Board To: DataFu , Jacob Tolar , Eyal Allweil Date: Wed, 28 Jun 2017 14:52:17 -0000 Message-ID: <20170628145217.20029.5898@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Eyal Allweil X-ReviewGroup: DataFu X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60396/ X-Sender: Eyal Allweil X-ReviewBoard-ShipIt: 1 References: <20170623185737.12281.13235@reviews-vm2.apache.org> In-Reply-To: <20170623185737.12281.13235@reviews-vm2.apache.org> Reply-To: Eyal Allweil X-ReviewRequest-Repository: datafu archived-at: Wed, 28 Jun 2017 14:52:26 -0000 --===============1830204357632680201== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60396/#review179112 ----------------------------------------------------------- Ship it! It looks good. The tests are definitely improved - it's easier to understand conceptually what each one is checking. - Eyal Allweil On June 23, 2017, 9:57 p.m., Jacob Tolar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60396/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 9:57 p.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > ------- > > DATAFU-124 sessionize() ought to support millisecond periods > > Update Sessionize() and SessionCount() constructor to support millisecond second duration. > Refactored tests for those two UDFs and added a couple new ones. > > I can revert the test refactor if that's cluttering things too much. > > > Diffs > ----- > > datafu-pig/src/main/java/datafu/pig/sessions/SessionCount.java fe68888 > datafu-pig/src/main/java/datafu/pig/sessions/Sessionize.java d81fb48 > datafu-pig/src/test/java/datafu/test/pig/sessions/SessionTests.java 76ec1d3 > > > Diff: https://reviews.apache.org/r/60396/diff/1/ > > > Testing > ------- > > ./gradlew :datafu-pig:test > > > Thanks, > > Jacob Tolar > > --===============1830204357632680201==--