datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eyal Allweil <eyal_allw...@yahoo.com>
Subject Re: Review Request 55110: DATAFU-106 Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*). For better organization, they should be created in a subdirectory.
Date Mon, 02 Jan 2017 09:29:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55110/#review160317
-----------------------------------------------------------



Hi Piyush,

Thank you for your patch! It looks to me that it works fine - I ran our tests on Ubuntu, both
from Eclipse and from the command line.

I have two comments, one "real" and one just a typo:

1) From [this question](http://stackoverflow.com/a/840229/150992), it appears that changing
the *user.dir* property in this way can be unpredictable - that it won't affect FileOutputStreams,
for example. So although this works for our current tests (the FileOutputStream used in datafu.pig.linkanalysis.PageRank
uses *File.createTempFile* instead of the working dir, so it's fine) I worry that this might
not work in the future. Maybe add a comment about this in the *beforeClass* method?

2) "Location" is spelled as "loaction" in PigTests.java

Cheers,
Eyal

- Eyal Allweil


On Dec. 31, 2016, 12:47 p.m., Piyush  Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55110/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2016, 12:47 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-106: Test files are currently created in the subdirectory folder (e.g. datafu-pig/input*).
For better organization, they should be created in a subdirectory. This also makes it easier
to exclude them all with gitignore. 
> (issue: https://issues.apache.org/jira/browse/DATAFU-106)
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/test/java/datafu/test/pig/PigTests.java d1d6fcc 
>   datafu-pig/src/test/java/datafu/test/pig/test_filesSubdir/TestFilesSubdirTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55110/diff/
> 
> 
> Testing
> -------
> 
> unit tests passed.
> 
> 
> Thanks,
> 
> Piyush  Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message