Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49AA618985 for ; Sat, 22 Aug 2015 14:19:56 +0000 (UTC) Received: (qmail 65853 invoked by uid 500); 22 Aug 2015 14:19:56 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 65795 invoked by uid 500); 22 Aug 2015 14:19:56 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 65780 invoked by uid 99); 22 Aug 2015 14:19:55 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Aug 2015 14:19:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9256DECD3F for ; Sat, 22 Aug 2015 14:19:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.898 X-Spam-Level: X-Spam-Status: No, score=0.898 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.883, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N6zr8FqCWvZY for ; Sat, 22 Aug 2015 14:19:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 9D44C383FB for ; Sat, 22 Aug 2015 09:11:46 +0000 (UTC) Received: (qmail 85021 invoked by uid 99); 22 Aug 2015 09:11:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Aug 2015 09:11:45 +0000 Date: Sat, 22 Aug 2015 09:11:45 +0000 (UTC) From: "Ido Hadanny (JIRA)" To: dev@datafu.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DATAFU-91) pig version of HyperLogLog estimator should be Algebraic and use combiners MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DATAFU-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707953#comment-14707953 ] Ido Hadanny commented on DATAFU-91: ----------------------------------- Hey [~matterhayes], sorry but I just can't seem to complete this patch :( Tried building on my windows machine and ran into a gradle/windows problem. https://discuss.gradle.org/t/error-with-a-copy-task-on-windows/1803 Please re-assign this issue to yourself and complete it - its just changing the `offer` to `offerHashed` and making sure everything works. Looking forward to see this in the next datafu version! > pig version of HyperLogLog estimator should be Algebraic and use combiners > -------------------------------------------------------------------------- > > Key: DATAFU-91 > URL: https://issues.apache.org/jira/browse/DATAFU-91 > Project: DataFu > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Ido Hadanny > Assignee: Ido Hadanny > Priority: Minor > Fix For: 1.3.0 > > Attachments: hyper-log-log-algebraic-3.diff, hyper-log-log-algebraic.diff, hyper-log-log-algebraic.diff > > > Matt: I don't remember if there was a particular reason I didn't implement this as AlgebraicEvalFunc. It seems like it could be. I believe the Java MapReduce version leverages the combiner. If you want to try making this Algebraic we would be happy to accept a patch :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)