Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1333119B9 for ; Sun, 20 Apr 2014 21:55:37 +0000 (UTC) Received: (qmail 47190 invoked by uid 500); 20 Apr 2014 21:55:37 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 47146 invoked by uid 500); 20 Apr 2014 21:55:37 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 47138 invoked by uid 99); 20 Apr 2014 21:55:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Apr 2014 21:55:37 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 20 Apr 2014 21:55:36 +0000 Received: (qmail 47078 invoked by uid 99); 20 Apr 2014 21:55:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Apr 2014 21:55:14 +0000 Date: Sun, 20 Apr 2014 21:55:14 +0000 (UTC) From: "Matthew Hayes (JIRA)" To: dev@datafu.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DATAFU-34) Add some UDFS to handle map type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DATAFU-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975294#comment-13975294 ] Matthew Hayes commented on DATAFU-34: ------------------------------------- MapToBag: * Line 77 in sample code has a less than sign that's not html-encoded. * Have you confirmed the type of the value that is produced for your tests? I think it would be good to have tests that verify that if you declared a map[int] then you get a bag with key string and value int. Also when the type of the map's value isn't declared, it should be bytearray, and we should confirm that the bag's value field is a bytearray. MapToTuple: * The output schema's tuple doesn't have a type declared. * Same comments as with MapToBag regarding testing the types. PutToMap: * Typo on 73: acutal * What if the type of the map is map[int] for instance and someone puts a string value. Does your code catch this? You should add a test case for this. By the way thanks for writing these :) These look pretty useful. > Add some UDFS to handle map type > -------------------------------- > > Key: DATAFU-34 > URL: https://issues.apache.org/jira/browse/DATAFU-34 > Project: DataFu > Issue Type: New Feature > Reporter: jian wang > Assignee: jian wang > Attachments: 0001-add-some-UDFs-to-manipulate-map.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)