Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45406FB8C for ; Mon, 28 Apr 2014 17:34:40 +0000 (UTC) Received: (qmail 209 invoked by uid 500); 28 Apr 2014 17:34:33 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 145 invoked by uid 500); 28 Apr 2014 17:34:32 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 99931 invoked by uid 99); 28 Apr 2014 17:34:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 17:34:30 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 28 Apr 2014 17:34:30 +0000 Received: (qmail 99031 invoked by uid 99); 28 Apr 2014 17:34:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 17:34:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3667E1D71BE; Mon, 28 Apr 2014 17:34:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6967538184002307300==" MIME-Version: 1.0 Subject: Re: Review Request 20786: DATAFU-42: Update BagGroup documentation From: "Matthew Hayes" To: "DataFu" , "Matthew Hayes" Date: Mon, 28 Apr 2014 17:34:00 -0000 Message-ID: <20140428173400.30655.5347@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Matthew Hayes" X-ReviewGroup: DataFu X-ReviewRequest-URL: https://reviews.apache.org/r/20786/ X-Sender: "Matthew Hayes" References: <20140428172620.30677.99360@reviews.apache.org> In-Reply-To: <20140428172620.30677.99360@reviews.apache.org> Reply-To: "Matthew Hayes" X-ReviewRequest-Repository: datafu X-Virus-Checked: Checked by ClamAV on apache.org --===============6967538184002307300== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20786/ ----------------------------------------------------------- (Updated April 28, 2014, 5:33 p.m.) Review request for DataFu. Changes ------- Fixed some issues with the javadoc. Repository: datafu Description ------- We should update the javadoc and test cases with an example of projecting the value from the output bag, dropping the key. The website should be updated as well with documentation on BagGroup. See https://issues.apache.org/jira/browse/DATAFU-42 for details. Diffs (updated) ----- datafu-pig/src/main/java/datafu/pig/bags/BagGroup.java 2359d6f datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java a8e0d32 site/source/docs/datafu/1.2.0/datafu/pig/bags/BagGroup.html 2f27539 site/source/docs/datafu/guide/bag-operations.html.markdown.erb 70d73c6 Diff: https://reviews.apache.org/r/20786/diff/ Testing ------- Thanks, Matthew Hayes --===============6967538184002307300==--