datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Hayes (JIRA)" <>
Subject [jira] [Commented] (DATAFU-34) Add some UDFS to handle map type
Date Sun, 20 Apr 2014 21:55:14 GMT


Matthew Hayes commented on DATAFU-34:

* Line 77 in sample code has a less than sign that's not html-encoded.
* Have you confirmed the type of the value that is produced for your tests?  I think it would
be good to have tests that verify that if you declared a map[int] then you get a bag with
key string and value int.  Also when the type of the map's value isn't declared, it should
be bytearray, and we should confirm that the bag's value field is a bytearray.

* The output schema's tuple doesn't have a type declared.
* Same comments as with MapToBag regarding testing the types.

* Typo on 73: acutal
* What if the type of the map is map[int] for instance and someone puts a string value.  Does
your code catch this?  You should add a test case for this.

By the way thanks for writing these :)  These look pretty useful.

> Add some UDFS to handle map type
> --------------------------------
>                 Key: DATAFU-34
>                 URL:
>             Project: DataFu
>          Issue Type: New Feature
>            Reporter: jian wang
>            Assignee: jian wang
>         Attachments: 0001-add-some-UDFs-to-manipulate-map.patch

This message was sent by Atlassian JIRA

View raw message