datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Hayes (JIRA)" <>
Subject [jira] [Commented] (DATAFU-34) Add some UDFS to handle map type
Date Sun, 20 Apr 2014 21:24:31 GMT


Matthew Hayes commented on DATAFU-34:

Can you open a review board?

Some comments:

* In exec(), should we check that the key isn't already in the map and throw an error if it
is?  Otherwise it could lead to unexpected behavior.
* Minor typos in sample code.  dump statements should end in semicolon.

* I think this method name could be confusing.  I was actually confused when I looked at the
example because I didn't realize at first the default was "any." It may be clearer to have
two methods: ContainsAllKeys and ContainsAnyKeys.  An abstract base class could have most
of the implementation.

> Add some UDFS to handle map type
> --------------------------------
>                 Key: DATAFU-34
>                 URL:
>             Project: DataFu
>          Issue Type: New Feature
>            Reporter: jian wang
>            Assignee: jian wang
>         Attachments: 0001-add-some-UDFs-to-manipulate-map.patch

This message was sent by Atlassian JIRA

View raw message