daffodil-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [daffodil] stevedlawrence commented on pull request #514: Update jansi to 2.3.2
Date Tue, 06 Apr 2021 12:38:13 GMT

stevedlawrence commented on pull request #514:
URL: https://github.com/apache/daffodil/pull/514#issuecomment-814085902

   From Mike:
   > Different dependencies for Windows/Unix bothers me quite a bit, particularly if we're
including windows-specific code that calls native code.
   > Are my concerns sensible? I know that deep down, the JVM is making system calls and
on Windows those may be different than on Linux. But the JVM itself is different than some
dependent libraries to me.
   I think it's sensible, but not sure what we can really do about it. Apparently windows
needs special help to make terminals work that way we they should.
   I think it's also worth pointing out that the jansi/jline dependencies are only dependencies
to the CLI jar, and the CLI jar is only distributed in the rpm/zip/tars. If you use maven/sbt
and depend on daffodil-japi or daffodil-sapi, the CLI and the jansi/jline dependencies are
not pulled in.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message