daffodil-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #374: Fixed issue with type casting on Variables
Date Wed, 29 Apr 2020 12:53:03 GMT

jadams-tresys commented on a change in pull request #374:
URL: https://github.com/apache/incubator-daffodil/pull/374#discussion_r417290249



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NodeInfo.scala
##########
@@ -410,15 +410,15 @@ object NodeInfo extends Enum {
     Byte,
     Short,
     Long,
-    Integer,
-    Decimal,
     UnsignedInt,
     UnsignedByte,
     UnsignedShort,
     UnsignedLong,
     NonNegativeInteger,
+    Integer,
     Double,
     Float,
+    Decimal,
     HexBinary,

Review comment:
       Yes, I meant to add something along those lines to the commit message, but I pushed
this up right before going to sleep and my groggy brain didn't remember.
   allPrimTypes definitely needs to be in order or most specific to least specific, as we
are doing a find(isSubTypeof(_)), which simply returns the first successful match.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message