Mailing-List: contact users-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@cxf.apache.org
Received-SPF: pass (athena.apache.org: domain of brice.dutheil@gmail.com
 designates 209.85.214.41 as permitted sender)
MIME-Version: 1.0
From: Brice Dutheil <brice.dutheil@gmail.com>
Date: Mon, 5 Nov 2012 20:27:46 +0100
Message-ID: 
 <CALTMA7vAYJvL73CLM1jo+6tP+2z+g_Mayo_e7JmmTi385mhCqA@mail.gmail.com>
Subject: Multipart values are not trimed
To: users@cxf.apache.org
Content-Type: multipart/alternative; boundary=000e0ce03bfa55502c04cdc47d20

--000e0ce03bfa55502c04cdc47d20
Content-Type: text/plain; charset=UTF-8

Hi,

I'm crafting a resource that should accept multipart POST request.

Here's the method :

================================================
  @POST
  @Produces({MediaType.APPLICATION_JSON})
  @Consumes(MediaType.MULTIPART_FORM_DATA)
  public MetaData archive(@FormParam("title") String title,
                                  @FormParam("revision") String revision,
                                  @Multipart("archive") TemporaryBinaryFile
temporaryBinaryFile) {
================================================

Also I tried with @Multipart instead of @FormParam

================================================
  @POST
  @Produces({MediaType.APPLICATION_JSON})
  @Consumes(MediaType.MULTIPART_FORM_DATA)
  public DocumentMetaData archive(@Multipart(value = "title", required =
false) @FormParam("title") String title,
                                  @Multipart(value = "revision", required =
false) String revision,
                                  @Multipart("archive") TemporaryBinaryFile
temporaryBinaryFile) {
================================================

And here is the raw request :
================================================
Address: http://localhost:8080/api/v1.0/document/archive
Encoding: ISO-8859-1
Http-Method: POST
Content-Type: multipart/form-data;boundary=partie
Headers: {Accept=[*/*], accept-charset=[ISO-8859-1,utf-8;q=0.7,*;q=0.3],
accept-encoding=[gzip,deflate,sdch], Content-Length=[301],
content-type=[multipart/form-data;boundary=partie]}
Payload:
--partie
Content-Disposition: form-data; name="title"
Content-ID: title

the.title
--partie
Content-Disposition: form-data; name="revision"
Content-ID: revision

some.revision
--partie
Content-Disposition: form-data; name="archive"; filename="file.txt"
Content-Type: text/plain

I've got a woman, way over town...
--partie
================================================

However the title and revision values are incorrect because they are ended
by a new line char '\n'. Hence these parameters are not validated by my
validator (which is using Message.getContent),

I don't think this is a normal behavior, but I might be wrong, maybe about
the specs, or my request. Note that I had to add the Content-ID when using
the Multipart annotation. Maybe there is something I should do ?


I have a workaround for that, I've made an interceptor whose role is to
trim strings. But I find it rather inelegant to do that.

Or am I missing something ?

Cheers
-- Brice

--000e0ce03bfa55502c04cdc47d20--