Mailing-List: contact users-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@cxf.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <019c01ca982c$329c0870$1f02050a@emea.progress.com>
From: Sergey Beryozkin <sberyozk@progress.com>
To: <users@cxf.apache.org>
References: <c8ce53501001121802i1302006ke8cb354feed3c97d@mail.gmail.com>
 <025e01ca9531$8dc478c0$1f02050a@emea.progress.com>
 <c8ce53501001140835u3e10736fhd27fa1cde88388d7@mail.gmail.com>
 <b18d40321001150624p4abb3239l78e6398327e5d8f3@mail.gmail.com>
 <010e01ca95f1$a89626b0$1f02050a@emea.progress.com>
 <b18d40321001180144x665e7fb8t492db75dc80e0d9b@mail.gmail.com>
Subject: Re: Access to HTTP cookie values in Interceptor or Invoker
 implementation?
Date: Mon, 18 Jan 2010 10:51:31 +0000
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit

Hi

> We have a single cookie header containing multiple values.
>
> Example:
> Cookie=user_token_w=amsterdam@vicio.com|1295428834|7mMx6SxeIeSaWhygsOsAyA==|Iy/1xl/kOwderfdsdhAg/ip1Qsb0dwerQOJ8zDYJ34=;
> user_logged_in=true
>
> I realized we are not encoding the cookie values,maybe this is the
> problem... I'm going to try right now.

Looks like the problem is that a ';' separator is used as a delimeter between multiple value, one cookie value is

"user_token_w=amsterdam@vicio.com|1295428834|7mMx6SxeIeSaWhygsOsAyA==|Iy/1xl/kOwderfdsdhAg/ip1Qsb0dwerQOJ8zDYJ34=;"

and another one is

"user_logged_in=true"

Is it possible for you to use a ',' as a separator ? Now, looking at [1] I can see

"Cookie:" cookie-version 1*((";" | ",") cookie-value)
so perhaps some cookies might contain a ',' as a separator between a version and the actual value, but all cookies I've seen so far 
do use ';'.

Also, I fixed yesterday an issue with multiple Cookie headers not being handled properly. So, right now, you need to use a ',' just 
before user_logged_in=true and starting from 2.2.6 (due in few days or so) you'd be able to use multiple Cookie headers as well...

cheers, Sergey

[1] http://tools.ietf.org/html/rfc2965


>
>
>
> Thanks,
> V.
>
> On Fri, Jan 15, 2010 at 3:47 PM, Sergey Beryozkin <sberyozk@progress.com>wrote:
>
>> Hi,
>>
>> do you have multiple Cookie headers or a single Cookie containing multiple
>> values :
>>
>> Cookie: a=b,c=d
>>
>> I can see a test confirming HttpHeaders.getCookies() returns a map
>> containing two entries.
>> Can you post a sample Cookie value I can add a test for ?
>>
>> thanks, Sergey
>>
>>
>>  The problem parsing multiple the header when having multiple cookies seems
>>> to be present also when injecting the HttpHeaders headers.
>>> headers.getCookies() returns only one cookie.
>>>
>>> Is there any Jira issue tracking this?
>>>
>>>
>>>
>>> Thanks,
>>> V.
>>>
>>> On Thu, Jan 14, 2010 at 5:35 PM, Michael Guyver <michael.guyver@gmail.com
>>> >wrote:
>>>
>>>  2010/1/14 Sergey Beryozkin <sberyozk@progress.com>:
>>>> > Hi
>>>> >
>>>> > One can write either a CXF interceptor or CXF JAXRS RequestHandler
>>>> filter,
>>>> > please see
>>>> >
>>>>
>>>> http://cxf.apache.org/docs/jax-rs.html#JAX-RS-DifferencebetweenJAXRSfiltersandCXFinterceptors
>>>> >
>>>> > If you do JAX-RS only then writing a filter could be a simpler option,
>>>> for
>>>> > ex, one can have JAXRS HttpHeaders injected into a custom filter :
>>>> >
>>>> > @Context
>>>> > private HttpHeaders headers;
>>>> >
>>>> > and then just do header.getCookies() in handleRequest();
>>>> >
>>>> > Alternatively, if you prefer to write a CXF interceptor then you can
>>>> get
>>>> to
>>>> > the cookies like this :
>>>> >
>>>> > String rawValue = new MetadataMap<String, String>(
>>>> >
>>>> > (Map<String,
>>>> >
>>>> List<String>>)message.get(Message.PROTOCOL_HEADERS)).getFirst("Cookie");
>>>> >
>>>> > Cookie c = Cookie.valueOf(rawValue);
>>>> >
>>>> > Note that the CXF HTTP transport does not split multiple header values
>>>> > (those separated by ',') so if the Cookie header contains multiple
>>>> cookies
>>>> > then you'd need to split thme first before doing
>>>>  Cookie.valueOf(rawValue);
>>>> >
>>>> > hope it helps, Sergey
>>>> >
>>>>
>>>> Hi Sergey,
>>>>
>>>> That's great, thanks very much for your help!
>>>>
>>>> Cheers
>>>>
>>>> Michael
>>>>
>>>>
>>>
>