Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C53A0200D54 for ; Fri, 8 Dec 2017 14:19:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3A66160C0D; Fri, 8 Dec 2017 13:19:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1B9A6160BF2 for ; Fri, 8 Dec 2017 14:19:11 +0100 (CET) Received: (qmail 96990 invoked by uid 500); 8 Dec 2017 13:19:11 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 96979 invoked by uid 99); 8 Dec 2017 13:19:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 13:19:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D891E1A0819 for ; Fri, 8 Dec 2017 13:19:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gAgh_zXJUXa5 for ; Fri, 8 Dec 2017 13:19:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 750F85F470 for ; Fri, 8 Dec 2017 13:19:09 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F19CE25A7 for ; Fri, 8 Dec 2017 13:19:07 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B882D273CB for ; Fri, 8 Dec 2017 13:19:04 +0000 (UTC) Date: Fri, 8 Dec 2017 13:19:04 +0000 (UTC) From: "Sergey Beryozkin (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-7584) proxy client: forbid empty path param MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 08 Dec 2017 13:19:13 -0000 [ https://issues.apache.org/jira/browse/CXF-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283503#comment-16283503 ] Sergey Beryozkin commented on CXF-7584: --------------------------------------- Hi Alexey Thanks for the patch, it looks fine for the purpose of making sure client proxies function correctly, but changing it at the UriBuilder is sensitive, at a pure URI building level providing an empty template value is not disallowedand as such may cause unexpected side-effects; please consider doing a basic check at the ClientProxyImpl level, where it is indeed problematic to supply empty path values as it may case unexpected call to say "GET orders" as opposed to "GET orders/1" :-), may be try to check at the end of ClientProxyImpl.getPathParamValues > proxy client: forbid empty path param > ------------------------------------- > > Key: CXF-7584 > URL: https://issues.apache.org/jira/browse/CXF-7584 > Project: CXF > Issue Type: Bug > Components: JAX-RS > Affects Versions: 3.2.1 > Reporter: Alexey Markevich > > {code} > @Path("/{p}") > void doSmth(@PathParam("p") String p); > {code} > invoked like > {code} > client.doSmth(""); > {code} > cause wrong endpoint called -- This message was sent by Atlassian JIRA (v6.4.14#64029)