cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <>
Subject [jira] [Commented] (CXF-7584) proxy client: forbid empty path param
Date Fri, 08 Dec 2017 13:19:04 GMT


Sergey Beryozkin commented on CXF-7584:

Hi Alexey
Thanks for the patch, it looks fine for the purpose of making sure client proxies function
correctly, but changing it at the UriBuilder is sensitive, at a pure URI building level providing
an empty template value is not disallowedand as such may cause unexpected side-effects; please
consider doing a basic check at the ClientProxyImpl level, where it is indeed problematic
to supply empty path values as it may case unexpected call to say "GET orders" as opposed
to "GET orders/1" :-), may be try to check at the end of ClientProxyImpl.getPathParamValues

> proxy client: forbid empty path param
> -------------------------------------
>                 Key: CXF-7584
>                 URL:
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.2.1
>            Reporter: Alexey Markevich
> {code}
> @Path("/{p}")
> void doSmth(@PathParam("p") String p);
> {code}
> invoked like
> {code}
> client.doSmth("");
> {code}
> cause wrong endpoint called

This message was sent by Atlassian JIRA

View raw message