Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 55777200498 for ; Tue, 29 Aug 2017 18:17:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 537DE161844; Tue, 29 Aug 2017 16:17:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A72E6160E18 for ; Tue, 29 Aug 2017 18:17:04 +0200 (CEST) Received: (qmail 54152 invoked by uid 500); 29 Aug 2017 16:17:03 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 54094 invoked by uid 99); 29 Aug 2017 16:17:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 16:17:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 093891A4C7B for ; Tue, 29 Aug 2017 16:17:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id dfzHYRVTkUin for ; Tue, 29 Aug 2017 16:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0A2C8611C3 for ; Tue, 29 Aug 2017 16:17:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 574C3E0EB5 for ; Tue, 29 Aug 2017 16:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4EFC82414F for ; Tue, 29 Aug 2017 16:17:00 +0000 (UTC) Date: Tue, 29 Aug 2017 16:17:00 +0000 (UTC) From: "Sergey Beryozkin (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FEDIZ-207) FedizPrincipal interface needs to have getId() method MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 29 Aug 2017 16:17:05 -0000 [ https://issues.apache.org/jira/browse/FEDIZ-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Beryozkin updated FEDIZ-207: ----------------------------------- Attachment: fediz207.txt This is a 1.4.x patch. Is there a reason it should only go to the master ? I'm pretty sure the only custom FedizPrincipal impl that is really affected here is the test one in the core. The global logout needs to work in 1.4.x > FedizPrincipal interface needs to have getId() method > ----------------------------------------------------- > > Key: FEDIZ-207 > URL: https://issues.apache.org/jira/browse/FEDIZ-207 > Project: CXF-Fediz > Issue Type: Improvement > Components: IDP, Plugin > Reporter: Sergey Beryozkin > Attachments: fediz207.txt > > > OIDC IDToken generates a random IdToken SubjectId value when it converts the values found in the FedizPrincipal's SAML token. The problem is that every time the user comes in a new subjectId is generated for the id token - while this value is actually expected to be identical for a given user. > The immediate problem we face is that every client application gets an IdToken for a user 'alice' with the different subjectId, thus. during the global logout, it is impossible for each of these client applications to identify, from the logout token, which user to logout - because when OIDC LogoutService creates a logout token it uses FedizSubjectCreator to create a new IdToken with a newly generated subject id. > One way to solve is to start hacking a solution involving saving it in a session id and then take care of removing it from the session on the logout - but given that every Fediz plugin takes care of dealing with FedizPrincipal it is better to keep 'id' at the FedizPrincipal level. > Updating the interface with getId() will only affect the plugins and not the user code. Each plugin will use UUID to generate it -- This message was sent by Atlassian JIRA (v6.4.14#64029)