Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Tue, 11 Jul 2017 09:29:00 +0000 (UTC)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.13036532.1484912645000.216231.1499765340625@Atlassian.JIRA>
In-Reply-To: <JIRA.13036532.1484912645000@Atlassian.JIRA>
References: <JIRA.13036532.1484912645000@Atlassian.JIRA> <JIRA.13036532.1484912645078@jira-lw-us.apache.org>
Subject: [jira] [Updated] (DOSGI-254) ServiceInvocationHandler does not
 handle checked super-interface exceptions correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 11 Jul 2017 09:38:58 -0000


     [ https://issues.apache.org/jira/browse/DOSGI-254?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated DOSGI-254:
--------------------------------------
    Fix Version/s: 2.3.0

> ServiceInvocationHandler does not handle checked super-interface exceptio=
ns correctly
> -------------------------------------------------------------------------=
------------
>
>                 Key: DOSGI-254
>                 URL: https://issues.apache.org/jira/browse/DOSGI-254
>             Project: CXF Distributed OSGi
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 2.0.0
>            Reporter: Panu H=C3=A4m=C3=A4l=C3=A4inen
>            Assignee: Christian Schneider
>             Fix For: 2.3.0
>
>
> If a remote service interface is composed of an interface hierarchy, the =
ServiceInvocationHandler (in org.apache.cxf.dosgi.dsw.handlers package on 1=
.7.0)  only handles correctly the checked exceptions of the interface the s=
ervice directly implements/exports (the lowest level interface of the hiera=
rchy). The checked exceptions of the superinterface methods are thrown as g=
eneric ServiceExceptions (which are RuntimeExceptions).=20
> For example below, the IOException thrown by the throwBaseException metho=
d gets converted to ServiceException while the URISyntaxException thrown by=
 the throwSubException method remains correctly as URISyntaxException. The =
service is exported as a TestSubInterface service.
> {code}
>     public interface TestBaseInterface {
>         void throwBaseException() throws IOException;
>     }
>    =20
>     public interface TestSubInterface extends TestBaseInterface {
>         void throwSubException() throws URISyntaxException;
>     }
>     public class TestClass implements TestSubInterface {
>         @Override
>         public void throwBaseException() throws IOException {
>             throw new IOException("expected baseinterface exception");
>         }
>         @Override
>         public void throwSubException() throws URISyntaxException {
>             throw new URISyntaxException("some input", "expected subinter=
face exception");
>         }
>     }
> {code}
> I have been using DOSGi 1.7.0 but I also checked version 2.0.0 and Servic=
eInvocationHandler (now in org.apache.cxf.dosgi.common.proxy package) seems=
 the same as in previous releases.
> The problem seems to be in ServiceInvocationHandler in the method
> {code}
>     private void introspectType(Class<?> iType) {
>         for (Method m : iType.getDeclaredMethods()) {
>             for (Class<?> excType : m.getExceptionTypes()) {
>                 if (Exception.class.isAssignableFrom(excType)) {
>                     List<Class<?>> types =3D exceptionsMap.get(m);
>                     if (types =3D=3D null) {
>                         types =3D new ArrayList<Class<?>>();
>                         exceptionsMap.put(m, types);
>                     }
>                     types.add(excType);
>                 }
>             }
>         }
>     }
> {code}
> for which the javadocs of  iType.getDeclaredMethods() say "Returns an arr=
ay of Method objects reflecting all the methods declared by the class or in=
terface represented by this Class object. This includes public, protected, =
default (package) access, and private methods, *but excludes inherited meth=
ods*."=20
> The introspectType method should be changed so that it also processes at =
least the public methods of the superinterfaces/classes. This can be achiev=
ed e.g. with iType.getMethods().


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)