cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7442) Improve handling of JSR 310 Date Time API
Date Wed, 12 Jul 2017 14:29:00 GMT

    [ https://issues.apache.org/jira/browse/CXF-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084059#comment-16084059
] 

Sergey Beryozkin commented on CXF-7442:
---------------------------------------

Hi, Do you mean shipping a LocalDate ParamConverter and possibly registered it OOB ? I'm not
sure, the code where the parameters are converted from String is probably the most active
code in the whole JAX-RS impl, so I'd be a bit concerned with everyone's code being affected
(checking the param converters for the types they may not use at all). It is very easy to
register a custom param converter and I guess keeping the application code more portable as
a result...  

> Improve handling of JSR 310 Date Time API
> -----------------------------------------
>
>                 Key: CXF-7442
>                 URL: https://issues.apache.org/jira/browse/CXF-7442
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 3.1.12
>            Reporter: Dennis Kieselhorst
>             Fix For: 3.2.0
>
>
> If a wrong date is given as param, the type is a JSR 310 Datatype and an XmlAdapter is
used, it will result in a ClassCastException. Moreover the catch block in org.apache.cxf.jaxrs.utils.JAXBUtils.useAdapter
logs using ex.printStackTrace(). I created a testcase in org.apache.cxf.jaxrs.utils.InjectionUtilsTest#testJsr310DateExceptionHandling.
> In my view it should end up in IllegalArgumentException/ createParamConversionException
as for other invalid params.
> General question: Since CXF 3.2 depends on Java 8 do we want to make JSR 310 handling
more convenient so that XmlAdapter stuff is no longer required?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message