Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Wed, 19 Apr 2017 15:57:41 +0000 (UTC)
From: "Andy McCright (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.13064783.1492533877000.319437.1492617461618@Atlassian.JIRA>
In-Reply-To: <JIRA.13064783.1492533877000@Atlassian.JIRA>
References: <JIRA.13064783.1492533877000@Atlassian.JIRA> <JIRA.13064783.1492533877121@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CXF-7339) NPE in
 org.apache.cxf.common.util.CacheMap.remove
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 19 Apr 2017 15:57:47 -0000


    [ https://issues.apache.org/jira/browse/CXF-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974955#comment-15974955 ] 

Andy McCright commented on CXF-7339:
------------------------------------

Hi Alessio,

This is a legitimate bug, but instead of using a null check JAXBContextCache code, could we redo the logic in CacheMap's remove method?  Prior to the change in CXF-5407, this map implementation was able to handle null keys, and (though I have not done a check to verify) it is possible that other places in code rely on the ability of CacheMap to handle null keys.  

If you'd rather I made the changes, please let me know.  Thanks for reporting this - and for the proposed fix.

Andy

> NPE in org.apache.cxf.common.util.CacheMap.remove
> -------------------------------------------------
>
>                 Key: CXF-7339
>                 URL: https://issues.apache.org/jira/browse/CXF-7339
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>            Reporter: Alessio Soldano
>            Assignee: Alessio Soldano
>             Fix For: 3.2.0, 3.1.12
>
>
> {noformat}
> 2017-04-17 19:12:28,910 INFO  [org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean] (MSC service thread 1-6) Creating Service {http://org.jboss.ws/jaxws/context}EndpointService from class org.jboss.test.ws.jaxws.samples.context.EndpointJSE
> 2017-04-17 19:12:28,915 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-6) MSC000001: Failed to start service jboss.deployment.unit."jaxws-samples-context-jse.war".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."jaxws-samples-context-jse.war".INSTALL: WFLYSRV0153: Failed to process phase INSTALL of deployment "jaxws-samples-context-jse.war"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:154)
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1948)
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1881)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.xml.ws.WebServiceException: java.lang.NullPointerException
> 	at org.apache.cxf.jaxws.EndpointImpl.doPublish(EndpointImpl.java:375)
> 	at org.jboss.wsf.stack.cxf.deployment.EndpointImpl.doPublish(EndpointImpl.java:79)
> 	at org.apache.cxf.jaxws.EndpointImpl.publish(EndpointImpl.java:255)
> 	at org.apache.cxf.jaxws.EndpointImpl.publish(EndpointImpl.java:543)
> 	at org.jboss.wsf.stack.cxf.configuration.BusHolder.configure(BusHolder.java:235)
> 	at org.jboss.wsf.stack.cxf.deployment.aspect.BusDeploymentAspect.startDeploymentBus(BusDeploymentAspect.java:97)
> 	at org.jboss.wsf.stack.cxf.deployment.aspect.BusDeploymentAspect.start(BusDeploymentAspect.java:59)
> 	at org.jboss.as.webservices.deployers.AspectDeploymentProcessor.deploy(AspectDeploymentProcessor.java:73)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:147)
> 	... 5 more
> Caused by: java.lang.NullPointerException
> 	at org.apache.cxf.common.util.CacheMap.remove(CacheMap.java:126)
> 	at org.apache.cxf.common.jaxb.JAXBContextCache.getCachedContextAndSchemas(JAXBContextCache.java:232)
> 	at org.apache.cxf.jaxb.JAXBDataBinding.createJAXBContextAndSchemas(JAXBDataBinding.java:472)
> 	at org.apache.cxf.jaxb.JAXBDataBinding.initialize(JAXBDataBinding.java:327)
> 	at org.apache.cxf.service.factory.AbstractServiceFactoryBean.initializeDataBindings(AbstractServiceFactoryBean.java:86)
> 	at org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean.buildServiceFromClass(ReflectionServiceFactoryBean.java:470)
> 	at org.apache.cxf.jaxws.support.JaxWsServiceFactoryBean.buildServiceFromClass(JaxWsServiceFactoryBean.java:696)
> 	at org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean.initializeServiceModel(ReflectionServiceFactoryBean.java:530)
> 	at org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean.create(ReflectionServiceFactoryBean.java:263)
> 	at org.apache.cxf.jaxws.support.JaxWsServiceFactoryBean.create(JaxWsServiceFactoryBean.java:199)
> 	at org.apache.cxf.frontend.AbstractWSDLBasedEndpointFactory.createEndpoint(AbstractWSDLBasedEndpointFactory.java:102)
> 	at org.apache.cxf.frontend.ServerFactoryBean.create(ServerFactoryBean.java:168)
> 	at org.apache.cxf.jaxws.JaxWsServerFactoryBean.create(JaxWsServerFactoryBean.java:211)
> 	at org.apache.cxf.jaxws.EndpointImpl.getServer(EndpointImpl.java:460)
> 	at org.apache.cxf.jaxws.EndpointImpl.doPublish(EndpointImpl.java:338)
> 	... 13 more
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)