cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FEDIZ-197) STSClientAction shouldn't change wsdlLocation when no port is set
Date Wed, 29 Mar 2017 11:41:42 GMT

    [ https://issues.apache.org/jira/browse/FEDIZ-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946963#comment-15946963
] 

ASF GitHub Bot commented on FEDIZ-197:
--------------------------------------

GitHub user gonzalad opened a pull request:

    https://github.com/apache/cxf-fediz/pull/15

    FEDIZ-197: wsdlLocation shouldn't be changed

    We should change wsdlLocation to use localPort
    only if port 0 has been explicitly set.
    
    Otherwise, we should use wsdlLocation as is.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gonzalad/cxf-fediz FEDIZ-197

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf-fediz/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 6cd9450a1784bbab264f961da68bded49d785aa5
Author: gonzalad <adr_gonzalez@yahoo.fr>
Date:   2017-03-29T07:15:10Z

    FEDIZ-197: wsdlLocation shouldn't be changed
    
    We should change wsdlLocation to use localPort
    only if port 0 has been explicitly set.
    
    Otherwise, we should use wsdlLocation as is.

commit 2b4dd28e5f8e79190e6862f83fc4843defd24d2b
Author: gonzalad <adr_gonzalez@yahoo.fr>
Date:   2017-03-29T11:39:03Z

    FEDIZ-197: Use local Port to call STS
    
    STSAuthenticationProvider now handles
    local port (:0) on wsdlLocation.
    If such a port is used for wsdlLocation,
    STSAuthenticationProvider will use the localServer port
    to retrieve the wsdl.
    
    Note: org.springframework.web.filter.RequestContextFilter needs
    to be set for this to work.

----


> STSClientAction shouldn't change wsdlLocation when no port is set
> -----------------------------------------------------------------
>
>                 Key: FEDIZ-197
>                 URL: https://issues.apache.org/jira/browse/FEDIZ-197
>             Project: CXF-Fediz
>          Issue Type: Improvement
>            Reporter: gonzalad
>            Priority: Trivial
>
> STSClientAction changes wsdlLocation port to localPort whenever we use a URL without
explicit port.
> For example, if we set wsdlLocation to http://fediz.com/sts and Fediz IDP server listens
on 8080, the used wsdlLocation will be changed to http://fediz.com:8080/sts 
> This is done to deploy easily IDP and STS apps in the same server.
> But it is not intuitive.
> From Colm feedback, we could use localPort only if port 0 has been explicitly defined:
>  * http://fediz.com:0/sts would be changed to http://fediz.com:8080/sts
>  * http://fediz.com/sts would be left unchanged



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message