Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A3313200C22 for ; Tue, 21 Feb 2017 15:21:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A1AE0160B68; Tue, 21 Feb 2017 14:21:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EA478160B3E for ; Tue, 21 Feb 2017 15:21:48 +0100 (CET) Received: (qmail 16757 invoked by uid 500); 21 Feb 2017 14:21:48 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 16746 invoked by uid 99); 21 Feb 2017 14:21:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 14:21:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B0018C65C4 for ; Tue, 21 Feb 2017 14:21:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.999 X-Spam-Level: X-Spam-Status: No, score=0.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R_bocHFbz_xr for ; Tue, 21 Feb 2017 14:21:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5B6E55FCD1 for ; Tue, 21 Feb 2017 14:21:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B5134E0657 for ; Tue, 21 Feb 2017 14:21:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2782B24127 for ; Tue, 21 Feb 2017 14:21:44 +0000 (UTC) Date: Tue, 21 Feb 2017 14:21:44 +0000 (UTC) From: "Sergey Beryozkin (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-6728) Review and improve the way EC keys are handled in JOSE code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Feb 2017 14:21:49 -0000 [ https://issues.apache.org/jira/browse/CXF-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876046#comment-15876046 ] Sergey Beryozkin commented on CXF-6728: --------------------------------------- org.apache.cxf.rs.security.jose.cookbook.JwsJoseCookBookTest.testECDSASignature > Review and improve the way EC keys are handled in JOSE code > ----------------------------------------------------------- > > Key: CXF-6728 > URL: https://issues.apache.org/jira/browse/CXF-6728 > Project: CXF > Issue Type: Improvement > Components: JAX-RS Security > Reporter: Sergey Beryozkin > Fix For: 3.2.0, 3.1.11 > > > The code which decodes/encodes JOSE EC key outputs needs to be reviewed. The current code was meant to be a more optimal version of the code available in Jose4J (which is actually a slightly improved version of the code found in Santuario plus dealing with JOSE specific optimizations). This code needs to be double-checked and if needed reverted to a version closer to the one found in Jose4J. > Curves: it should be possible to deduce the values from the current EC key as opposed to having users configure them explicitly. > Next, > https://tools.ietf.org/html/draft-ietf-jose-cfrg-curves-00 > has just come out, so I guess EC code will need to be updated accordingly. > I also recall that if EC keys are loaded from JKS then the default algorithm needs be set correctly if EC signature/enc algo is not set, at the moment it is always set to RS256 by default -- This message was sent by Atlassian JIRA (v6.3.15#6346)