Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Fri, 20 Jan 2017 11:58:26 +0000 (UTC)
From: =?utf-8?Q?Panu_H=C3=A4m=C3=A4l=C3=A4inen_=28JIRA=29?= <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.13036532.1484912645000.62077.1484913506457@Atlassian.JIRA>
In-Reply-To: <JIRA.13036532.1484912645000@Atlassian.JIRA>
References: <JIRA.13036532.1484912645000@Atlassian.JIRA> <JIRA.13036532.1484912645078@jira-lw-us.apache.org>
Subject: [jira] [Updated] (DOSGI-254) ServiceInvocationHandler does not
 handle checked super-interface exceptions correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 20 Jan 2017 11:58:32 -0000


     [ https://issues.apache.org/jira/browse/DOSGI-254?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:all-tabpanel ]

Panu H=C3=A4m=C3=A4l=C3=A4inen updated DOSGI-254:
----------------------------------
    Description:=20
If a remote service interface is composed of an interface hierarchy, the Se=
rviceInvocationHandler (in org.apache.cxf.dosgi.dsw.handlers package)  only=
 handles correctly the checked exceptions of the interface the service dire=
ctly implements (the lowest level interface of the hierarchy). The checked =
exceptions of the super-interface methods are thrown as generic ServiceExce=
ptions (which are RuntimeExceptions).=20

For example below, the IOException thrown by the throwBaseException method =
gets converted to ServiceException while the URISyntaxException thrown by t=
he throwSubException method remains correctly as URISyntaxException. The se=
rvice is exported as a TestSubInterface service.

{code}
    public interface TestBaseInterface {
        void throwBaseException() throws IOException;
    }
   =20
    public interface TestSubInterface extends TestBaseInterface {
        void throwSubException() throws URISyntaxException;
    }

    public class TestClass implements TestSubInterface {
        @Override
        public void throwBaseException() throws IOException {
            throw new IOException("expected baseinterface exception");
        }

        @Override
        public void throwSubException() throws URISyntaxException {
            throw new URISyntaxException("some input", "expected subinterfa=
ce exception");
        }
    }
{code}

I have been using DOSGi 1.7.0 but I also checked version 2.0.0 and ServiceI=
nvocationHandler (now in org.apache.cxf.dosgi.common.proxy package) seems t=
he same as in previous releases.

The problem seems to be in ServiceInvocationHandler in the method
{code}
    private void introspectType(Class<?> iType) {
        for (Method m : iType.getDeclaredMethods()) {
            for (Class<?> excType : m.getExceptionTypes()) {
                if (Exception.class.isAssignableFrom(excType)) {
                    List<Class<?>> types =3D exceptionsMap.get(m);
                    if (types =3D=3D null) {
                        types =3D new ArrayList<Class<?>>();
                        exceptionsMap.put(m, types);
                    }
                    types.add(excType);
                }
            }
        }
    }
{code}
for which the javadocs of  iType.getDeclaredMethods() say "Returns an array=
 of Method objects reflecting all the methods declared by the class or inte=
rface represented by this Class object. This includes public, protected, de=
fault (package) access, and private methods, *but excludes inherited method=
s*."

  was:
If a remote service interface is composed of an interface hierarchy, the Se=
rviceInvocationHandler (in org.apache.cxf.dosgi.dsw.handlers package)  only=
 handles correctly the checked exceptions of the interface the service dire=
ctly implements (the lowest level interface of the hierarchy). The checked =
exceptions of the super-interface methods are thrown as generic ServiceExce=
ptions (which are RuntimeExceptions).=20

For example below, the IOException thrown by the throwBaseException method =
gets converted to ServiceException while the URISyntaxException thrown by t=
he throwSubException method remains correctly as URISyntaxException. The se=
rvice is exported as a TestSubInterface service.

{code}
    public interface TestBaseInterface {
        void throwBaseException() throws IOException;
    }
   =20
    public interface TestSubInterface extends TestBaseInterface {
        void throwSubException() throws URISyntaxException;
    }

    public class TestClass implements TestSubInterface {
        @Override
        public void throwBaseException() throws IOException {
            throw new IOException("expected baseinterface exception");
        }

        @Override
        public void throwSubException() throws URISyntaxException {
            throw new URISyntaxException("some input", "expected subinterfa=
ce exception");
        }
    }
{code}

I have been using DOSGi 1.7.0 but I also checked version 2.0.0 and ServiceI=
nvocationHandler (now in org.apache.cxf.dosgi.common.proxy package) seems t=
he same as in previous releases.


> ServiceInvocationHandler does not handle checked super-interface exceptio=
ns correctly
> -------------------------------------------------------------------------=
------------
>
>                 Key: DOSGI-254
>                 URL: https://issues.apache.org/jira/browse/DOSGI-254
>             Project: CXF Distributed OSGi
>          Issue Type: Bug
>          Components: DSW
>    Affects Versions: 2.0.0
>            Reporter: Panu H=C3=A4m=C3=A4l=C3=A4inen
>
> If a remote service interface is composed of an interface hierarchy, the =
ServiceInvocationHandler (in org.apache.cxf.dosgi.dsw.handlers package)  on=
ly handles correctly the checked exceptions of the interface the service di=
rectly implements (the lowest level interface of the hierarchy). The checke=
d exceptions of the super-interface methods are thrown as generic ServiceEx=
ceptions (which are RuntimeExceptions).=20
> For example below, the IOException thrown by the throwBaseException metho=
d gets converted to ServiceException while the URISyntaxException thrown by=
 the throwSubException method remains correctly as URISyntaxException. The =
service is exported as a TestSubInterface service.
> {code}
>     public interface TestBaseInterface {
>         void throwBaseException() throws IOException;
>     }
>    =20
>     public interface TestSubInterface extends TestBaseInterface {
>         void throwSubException() throws URISyntaxException;
>     }
>     public class TestClass implements TestSubInterface {
>         @Override
>         public void throwBaseException() throws IOException {
>             throw new IOException("expected baseinterface exception");
>         }
>         @Override
>         public void throwSubException() throws URISyntaxException {
>             throw new URISyntaxException("some input", "expected subinter=
face exception");
>         }
>     }
> {code}
> I have been using DOSGi 1.7.0 but I also checked version 2.0.0 and Servic=
eInvocationHandler (now in org.apache.cxf.dosgi.common.proxy package) seems=
 the same as in previous releases.
> The problem seems to be in ServiceInvocationHandler in the method
> {code}
>     private void introspectType(Class<?> iType) {
>         for (Method m : iType.getDeclaredMethods()) {
>             for (Class<?> excType : m.getExceptionTypes()) {
>                 if (Exception.class.isAssignableFrom(excType)) {
>                     List<Class<?>> types =3D exceptionsMap.get(m);
>                     if (types =3D=3D null) {
>                         types =3D new ArrayList<Class<?>>();
>                         exceptionsMap.put(m, types);
>                     }
>                     types.add(excType);
>                 }
>             }
>         }
>     }
> {code}
> for which the javadocs of  iType.getDeclaredMethods() say "Returns an arr=
ay of Method objects reflecting all the methods declared by the class or in=
terface represented by this Class object. This includes public, protected, =
default (package) access, and private methods, *but excludes inherited meth=
ods*."


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)