cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7164) Support tracing using Zipkin Brave
Date Thu, 29 Dec 2016 11:13:58 GMT

    [ https://issues.apache.org/jira/browse/CXF-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785122#comment-15785122
] 

Sergey Beryozkin commented on CXF-7164:
---------------------------------------

Hey Andriy

It looks very neat IMHO, the re-use of the rt/management code is cool.
The 'jaxws' BraveFeature can be used for JAXRS too - if JAXRS users decide to go with the
CXF interceptors then they'd want to use a CXF feature which loads those CXF interceptors
:-), I just moved the feature into a 'brave' subpackage, hope you are OK with it. Of course,
a 'jaxws' subpackage can be reintroduced should something really JAXWS specific gets involved.

But what do we do with jaxrs/BraveFeature ? I'd like to suggest that this is updated around
a JAX-RS 2.0 Feature - so that the JAX-RS users can indeed use a *portable* JAX-RS 2.0 code
to register it. Otherwise it is not really that useful, CXF JAXRS users can still use a 'brave'
BraveFeature and get the same level of tracing. 
Would you like to try to refactor the jaxrs Feature, I thought you might be interested ? 

Thanks

> Support tracing using Zipkin Brave
> ----------------------------------
>
>                 Key: CXF-7164
>                 URL: https://issues.apache.org/jira/browse/CXF-7164
>             Project: CXF
>          Issue Type: New Feature
>          Components: Tracing Brave
>    Affects Versions: 3.1.7
>            Reporter: Christian Schneider
>            Assignee: Andriy Redko
>             Fix For: 3.2.0
>
>
> Reference to the relevant discussion: https://github.com/openzipkin/brave/issues/313



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message