Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C196200BC3 for ; Thu, 3 Nov 2016 15:47:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4AB38160AFF; Thu, 3 Nov 2016 14:47:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 795A5160B0B for ; Thu, 3 Nov 2016 15:47:00 +0100 (CET) Received: (qmail 84171 invoked by uid 500); 3 Nov 2016 14:46:59 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 84086 invoked by uid 99); 3 Nov 2016 14:46:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 14:46:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4CE852C2ABF for ; Thu, 3 Nov 2016 14:46:59 +0000 (UTC) Date: Thu, 3 Nov 2016 14:46:59 +0000 (UTC) From: "Joe Luo (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-7114) Disable HTTP TRACE method on CXF http-jetty transport MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 03 Nov 2016 14:47:01 -0000 [ https://issues.apache.org/jira/browse/CXF-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632948#comment-15632948 ] Joe Luo commented on CXF-7114: ------------------------------ {quote} And should it be 405 status instead of 500 ? {quote} Yeah, you were right, It should return 405 instead of 500. please find a new patch.txt attached. It sets Jetty Server Request "handled" status to true and HttpServletResponse to status 405 instead of simply throwing back a ServletException. {quote} Should it be optionally disabled (you mentioned Pax Web disabling it by default) ? {quote} Yeah, Pax Web disabled it by default. But it was just simply throwing back a ServletException so it was status of 500 returned back to client. I do not mind to have it optionally disabled. But I doubt that the TRACE method is still used by anyone now. Particularly, it is only for standalone CXF endpoints using http-jetty transport. > Disable HTTP TRACE method on CXF http-jetty transport > ----------------------------------------------------- > > Key: CXF-7114 > URL: https://issues.apache.org/jira/browse/CXF-7114 > Project: CXF > Issue Type: Bug > Components: Transports > Affects Versions: 3.0.4 > Reporter: Joe Luo > Priority: Minor > Attachments: patch.txt > > > We had a security scan and found that standalone CXF endpoint using http-jetty transport still had HTTP TRACE method enabled. It is considered as a security risk. > It's not a problem if the CXF http-jetty transport is used with Pax Web as Pax Web had already had it's embedded Jetty engine's HTTP TRACE method disabled by default. > So we should disable HTTP TRACE method in JettyHTTPHandler. Please find attached patch.txt for more detail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)