cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7075) Remove unnecessary string.length() and map.containsKey(...) calls to improve performance
Date Wed, 12 Oct 2016 13:38:20 GMT

    [ https://issues.apache.org/jira/browse/CXF-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568731#comment-15568731
] 

Sergey Beryozkin commented on CXF-7075:
---------------------------------------

Hi Andy

I've applied the code highlighted here:

https://issues.apache.org/jira/browse/CXF-7075?focusedCommentId=15549928&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15549928

with the minor modifications - some tests were failing: if media types had no spaces between
them hence trim() was also required, or if the string had a trailing ',' - which I believe
can happen sometimes with Accept). 

Thanks, Sergey

> Remove unnecessary string.length() and map.containsKey(...) calls to improve performance
> ----------------------------------------------------------------------------------------
>
>                 Key: CXF-7075
>                 URL: https://issues.apache.org/jira/browse/CXF-7075
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 3.1.7
>            Reporter: Andy McCright
>            Assignee: Sergey Beryozkin
>             Fix For: 3.2.0, 3.1.8, 3.0.11
>
>         Attachments: JAXRSUtils-parseMediaType-perfTest.zip
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Using a simple (echo) JAX-RS benchmark, we've found a few hot spots around string.length()
and map.containsKey(...) calls that could be optimized.  Initial testing with the proposed
changes yielded about a 2-3% improvement.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message