cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neal Hu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7071) HttpServletRequest.getParameter only get String from query not both posted form data
Date Fri, 30 Sep 2016 06:41:20 GMT

    [ https://issues.apache.org/jira/browse/CXF-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535216#comment-15535216
] 

Neal Hu commented on CXF-7071:
------------------------------

Or do you have a case where a POST request can have either HTTP query or form payload ?-->Yes,
the request either has the form payload or query for the same resource. So we need make our
resource class like:
{code:java}
@POST
    @Path("beanparam")
    @Produces(MediaType.TEXT_PLAIN)
    @Consumes({MediaType.APPLICATION_FORM_URLENCODED, MediaType.APPLICATION_JSON})
    @ApiOperation(value = "beanParam")
    String beanParam(@BeanParam TalkListParam param, @Context HttpServletRequest req, @HeaderParam(value
= "ak") String ak);

public class TalkListParam  {

   @QueryParam(value = "pageIndex")
   private Integer currentPage;

    @FormParam(value = "pageIndex")
    @ApiParam(value = "页码-ios", required = false, defaultValue = "1")
    private Integer currentPageIOS=1;

}
{code}

But if we use the servlet api, we can simply get the data via request.getParameter("pageIndex"),
now if the inputsteam parsed by cxf will not follow  the servlet api spec.


> HttpServletRequest.getParameter only get String from query not both posted form data
> ------------------------------------------------------------------------------------
>
>                 Key: CXF-7071
>                 URL: https://issues.apache.org/jira/browse/CXF-7071
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.7
>            Reporter: Neal Hu
>             Fix For: 3.1.8
>
>
> The http request:
>  POST /dubbott-demo-provider/v1.0/users/beanparam HTTP/1.1
> HOST: localhost:8080
> accept: text/plain
> content-type: application/x-www-form-urlencoded
> content-length: 12
> pageIndex=99
> The resource method returns null:
> {code:java}
>     public String beanParam(@Context HttpServletRequest req, String ak) {
>         String pageIndex = req.getParameter("pageIndex")    
>         return pageIndex;
>     }
> {code}
> From the servlet 3.1 API doc:
> String javax.servlet.ServletRequest.getParameter(String name)
> Returns the value of a request parameter as a String, or null if the parameter does not
exist. Request parameters are extra information sent with the request. For HTTP servlets,
parameters are contained in the query string or posted form data.
> if we add below servlet filter:
> {code:java}
> 	public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
throws IOException, ServletException {
> 	        System.out.println(request.getParameter("pageIndex") );
> 		chain.doFilter(request, response);
> 	}
> {code}
> The output is "99" the response is the same "99".
> As a conclusion the CXF HttpServletRequest doesn't comply the Servlet 3.1 API Spec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message