cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7042) review some jaxrs client defaults: thread safe and split headers
Date Wed, 07 Sep 2016 10:43:20 GMT

    [ https://issues.apache.org/jira/browse/CXF-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470265#comment-15470265
] 

Romain Manni-Bucau commented on CXF-7042:
-----------------------------------------

About link (easiest issue):
- here are the client (@Test) and server (@GET): https://github.com/apache/tomee/blob/master/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/LinkTest.java#L40
- without "org.apache.cxf.http.header.split"=true it just fails with an invalid URI cause
the value is both links separated by ',' as expected

About thread safety: I kind of get the technical/cxf concerns but since several talks encouraged
this kind of programming I wonder if we can enhance it a bit by default (making request not
mutating the client config would be one quick win probably)

> review some jaxrs client defaults: thread safe and split headers
> ----------------------------------------------------------------
>
>                 Key: CXF-7042
>                 URL: https://issues.apache.org/jira/browse/CXF-7042
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Romain Manni-Bucau
>
> Hi
> putting it as "bug" but can be "improvement" depending how you see it
> I'd like we take a moment to review 2 properties of the client:
> - thread.safe.client: i think the default should be true since the spec is thread safe
> - org.apache.cxf.http.header.split (AbstractClient): issue not being true by default
is it breaks some natural JAXRS round trips like Link: your server sends Link header with
2 values, client (response.getLinks()) is not able to read it. If it is about performances,
known headers (the ones wrapped by some higher level API in JAXRS) should at least be handled
properly by default.
> Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse concatenate
headers properly for multiple values but not for Link header cause of org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY,
not sure it is intended
> wdyt?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message