cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CXF-7042) review some jaxrs client defaults: thread safe and split headers
Date Wed, 07 Sep 2016 07:53:20 GMT

     [ https://issues.apache.org/jira/browse/CXF-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Romain Manni-Bucau updated CXF-7042:
------------------------------------
    Description: 
Hi

putting it as "bug" but can be "improvement" depending how you see it

I'd like we take a moment to review 2 properties of the client:

- thread.safe.client: i think the default should be true since the spec is thread safe
- org.apache.cxf.http.header.split (AbstractClient): issue not being true by default is it
breaks some natural JAXRS round trips like Link: your server sends Link header with 2 values,
client (response.getLinks()) is not able to read it. If it is about performances, known headers
(the ones wrapped by some higher level API in JAXRS) should at least be handled properly by
default.

Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse concatenate headers
properly for multiple values but not for Link header cause of org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY,
not sure it is intended

wdyt?

  was:
Hi

putting it as "bug" but can be "improvement" depending how you see it

I'd like we take a moment to review 2 properties of the client:

- thread.safe.client: i think the default should be true since the spec is thread safe
- org.apache.cxf.http.header.split (AbstractClient): issue not being true by default is it
breaks some natural JAXRS round trips like Link: your server sends Link header with 2 values,
client (response.getLinks()) is not able to read it. If it is about performances, known headers
(the ones wrapped by some higher level API in JAXRS) should at least be handled properly by
default.

Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse concatenate headers
properly for multiple values but not for Link headers, not sure it is intended

wdyt?


> review some jaxrs client defaults: thread safe and split headers
> ----------------------------------------------------------------
>
>                 Key: CXF-7042
>                 URL: https://issues.apache.org/jira/browse/CXF-7042
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Romain Manni-Bucau
>
> Hi
> putting it as "bug" but can be "improvement" depending how you see it
> I'd like we take a moment to review 2 properties of the client:
> - thread.safe.client: i think the default should be true since the spec is thread safe
> - org.apache.cxf.http.header.split (AbstractClient): issue not being true by default
is it breaks some natural JAXRS round trips like Link: your server sends Link header with
2 values, client (response.getLinks()) is not able to read it. If it is about performances,
known headers (the ones wrapped by some higher level API in JAXRS) should at least be handled
properly by default.
> Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse concatenate
headers properly for multiple values but not for Link header cause of org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY,
not sure it is intended
> wdyt?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message