Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4EF01200B72 for ; Fri, 26 Aug 2016 16:25:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4DCE6160AB0; Fri, 26 Aug 2016 14:25:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F9A1160AB6 for ; Fri, 26 Aug 2016 16:25:23 +0200 (CEST) Received: (qmail 41394 invoked by uid 500); 26 Aug 2016 14:25:21 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 41010 invoked by uid 99); 26 Aug 2016 14:25:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Aug 2016 14:25:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 496672C0159 for ; Fri, 26 Aug 2016 14:25:21 +0000 (UTC) Date: Fri, 26 Aug 2016 14:25:21 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-7026) o.a.c.transport.http.osgi.HttpServiceTrackerCust service leak MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 26 Aug 2016 14:25:24 -0000 [ https://issues.apache.org/jira/browse/CXF-7026?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D154391= 30#comment-15439130 ]=20 ASF GitHub Bot commented on CXF-7026: ------------------------------------- GitHub user grgrzybek opened a pull request: https://github.com/apache/cxf/pull/162 [CXF-7026] o.a.c.transport.http.osgi.HttpServiceTrackerCust#removedSe= =E2=80=A6 =E2=80=A6rvice was not called You can merge this pull request into a Git repository by running: $ git pull https://github.com/grgrzybek/cxf master-CXF-7026 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cxf/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 =20 ---- commit 09712af17f75e9d81d05718e8270cc3741e276db Author: Grzegorz Grzybek Date: 2016-08-26T14:23:52Z [CXF-7026] o.a.c.transport.http.osgi.HttpServiceTrackerCust#removedServ= ice was not called ---- > o.a.c.transport.http.osgi.HttpServiceTrackerCust service leak > ------------------------------------------------------------- > > Key: CXF-7026 > URL: https://issues.apache.org/jira/browse/CXF-7026 > Project: CXF > Issue Type: Bug > Components: OSGi > Affects Versions: 3.1.7 > Reporter: Grzegorz Grzybek > > During memory leak search I saw some old registrations of {{org.apache.cx= f.transport.servlet.CXFNonSpringServlet}}. Here's GC root path: > {noformat} > this - value: org.eclipse.jetty.server.ServerConnector$ServerConnecto= rManager #1 > <- _manager - class: org.eclipse.jetty.server.ServerConnector, value= : org.eclipse.jetty.server.ServerConnector$ServerConnectorManager #1 > <- [0] - class: java.lang.Object[], value: org.eclipse.jetty.server= .ServerConnector #1 > <- array - class: java.util.concurrent.CopyOnWriteArrayList, value= : java.lang.Object[] #17136 > <- _connectors - class: org.ops4j.pax.web.service.jetty.internal.= JettyServerWrapper, value: java.util.concurrent.CopyOnWriteArrayList #521 > <- _server - class: org.ops4j.pax.web.service.jetty.internal.Htt= pServiceServletHandler, value: org.ops4j.pax.web.service.jetty.internal.Jet= tyServerWrapper #1 > <- _servletHandler - class: org.eclipse.jetty.servlet.ServletHo= lder, value: org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHan= dler #1 > <- this$0 - class: org.eclipse.jetty.servlet.ServletHolder$Con= fig, value: org.eclipse.jetty.servlet.ServletHolder #1 > <- config - class: org.apache.cxf.transport.servlet.CXFNonSpr= ingServlet, value: org.eclipse.jetty.servlet.ServletHolder$Config #1 > <- servlet - class: org.apache.cxf.transport.http.osgi.Servl= etExporter, value: org.apache.cxf.transport.servlet.CXFNonSpringServlet #1 > <- m_svcObj - class: org.apache.felix.framework.ServiceRegi= strationImpl, value: org.apache.cxf.transport.http.osgi.ServletExporter #1 > <- [2] - class: org.osgi.framework.ServiceRegistration[], = value: org.apache.felix.framework.ServiceRegistrationImpl #311 > <- value - class: java.util.HashMap$Node, value: org.osgi= .framework.ServiceRegistration[] #87 > <- [179] - class: java.util.HashMap$Node[], value: java.= util.HashMap$Node #47874 > <- table - class: java.util.HashMap, value: java.util.H= ashMap$Node[] #9801 > <- m - class: java.util.Collections$SynchronizedMap, v= alue: java.util.HashMap #84 > <- m_regsMap - class: org.apache.felix.framework.Serv= iceRegistry, value: java.util.Collections$SynchronizedMap #7 > <- m_registry (Java frame) - class: org.apache.felix= .framework.FrameworkStartLevelImpl, value: org.apache.felix.framework.Servi= ceRegistry #1 > {noformat} > which shows that CXF servlet prevents from freeing previous instance of {= {org.eclipse.jetty.server.ServerConnector}}. > After some debugging, I've found that {{org.apache.cxf.transport.http.osg= i.HttpServiceTrackerCust#removedService()}} isn't called - why? because {{o= rg.apache.cxf.transport.http.osgi.HttpServiceTrackerCust#addingService()}} = returns {{null}}... -- This message was sent by Atlassian JIRA (v6.3.4#6332)