cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-7000) Allow logging to be enabled on-the-fly
Date Mon, 15 Aug 2016 11:08:21 GMT

    [ https://issues.apache.org/jira/browse/CXF-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420851#comment-15420851
] 

Sergey Beryozkin commented on CXF-7000:
---------------------------------------

Hi, no, in the interceptors one would do
{code:java}
// AbstractLoggingInterceptor
    protected static boolean isLoggingDisabled(Message message) throws Fault {
        Object liveLoggingProp = message.getContextualProperty("org.apache.cxf.logging.enable");
        return liveLoggingProp != null && PropertyUtils.isFalse(liveLoggingProp);
    }
    // LoggingIn/Out interceptors
    public void handleMessage(Message message) throws Fault {
        // skip logging only if "org.apache.cxf.logging.enable" is explicitly set to false
        if (isLoggingDisabled(message)) {
            return; 
        }
        // continue
    }
{code} 

This will work irrespectively of how these interceptors have been added, via a system "org.apache.cxf.logging.enable"=true
or manually on the client'/server factory bean or via bus.

What I mentioned earlier though than now it may be possible, on the client side, do per-client
as opposed to per-bus logging. Or per-response on the server.

It does add a minor initial overhead but the contextual properties are cached.

I do like your idea of the dynamic, on the fly logging. I'm only trying to see if adding a
feature does not add anything of its own can be avoided. thanks


> Allow logging to be enabled on-the-fly
> --------------------------------------
>
>                 Key: CXF-7000
>                 URL: https://issues.apache.org/jira/browse/CXF-7000
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core, logging
>    Affects Versions: 3.1.7
>            Reporter: Ingo Weiss
>
> Allow the logging feature to be enabled on-the-fly without restarting the bus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message