cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6998) Manual resolve ApplicationPath from parent classes as well.
Date Mon, 08 Aug 2016 02:43:20 GMT

    [ https://issues.apache.org/jira/browse/CXF-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411194#comment-15411194
] 

ASF GitHub Bot commented on CXF-6998:
-------------------------------------

Github user reta commented on a diff in the pull request:

    https://github.com/apache/cxf/pull/154#discussion_r73816714
  
    --- Diff: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
---
    @@ -939,21 +939,29 @@ public static boolean isValidResourceClass(Class<?> c) {
             }
             return true;
         }
    -    
    +
    +    public static ApplicationPath locateApplicationPath(Class<?> appClass) {
    +        ApplicationPath appPath = appClass.getAnnotation(ApplicationPath.class);
    +        if (appPath == null && appClass.getSuperclass() != Application.class)
{
    --- End diff --
    
    I may be wrong here, but solving issue proxies we are going against JAX-RS 2.0 spec:
    ```
    3.6 Annotation Inheritance
    ... Note that inheritance of class or interface annotations is not supported. ...
    ```
    
    Does it make sense to limit the scope by identifying the particular use case that CXF
dials with proxy (may be using Proxy.isProxyClass or alike) and only then fall back to super
class hierarchy?


> Manual resolve ApplicationPath from parent classes as well.
> -----------------------------------------------------------
>
>                 Key: CXF-6998
>                 URL: https://issues.apache.org/jira/browse/CXF-6998
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>            Reporter: John D. Ament
>
> The ApplicationPath annotation is not inherited.  As a result, when proxies are used
(for things like CDI integration), those proxies do not have the application path defined.
 As a result, the base URI is ignored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message