cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6904) Unable to read swagger annotations if the file is in another osgi bundle
Date Sun, 21 Aug 2016 19:49:21 GMT

    [ https://issues.apache.org/jira/browse/CXF-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429877#comment-15429877
] 

ASF GitHub Bot commented on CXF-6904:
-------------------------------------

GitHub user splatch opened a pull request:

    https://github.com/apache/cxf/pull/161

    CXF-6904 Customize Swagger scan logic so it doesn't hurt in OSGi.

    This PR overrides bean config and allows to use most of it's code used for swagger configuration.
This keeps default behavior of swagger, with some small difference that when scan on Swagger2Feature
is disabled it passes classes which are available on endpoint.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/splatch/cxf CXF-6904

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 5b12935081fcc2f97baf930e47955c1eaf2bbd0e
Author: Ɓukasz Dywicki <luke@code-house.org>
Date:   2016-08-21T19:35:11Z

    CXF-6904 Customize Swagger scan logic so it doesn't hurt in OSGi.

----


> Unable to read swagger annotations if the file is in another osgi bundle
> ------------------------------------------------------------------------
>
>                 Key: CXF-6904
>                 URL: https://issues.apache.org/jira/browse/CXF-6904
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS, OSGi
>            Reporter: Christian Lutz
>
> I created a simple example to reproduce the error.
> https://github.com/ChristianLutz/cxf-swagger-osgi-bug
> =================
> JAX-RS Swagger2Feature OSGI Issue
> =================
> This example is based on the code from 
> https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/description_swagger2_osgi
> How to reproduce the issue:
>   mvn install (on the example)
>   bin/karaf (I used the current karaf 4.0.5)
>   
>   on karaf@root()>
>   feature:repo-add cxf 3.1.6
>   feature:install cxf-rs-description-swagger2
>   install mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-base/2.6.5
>   install mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider/2.6.5
>   install -s mvn:de.kreeloo/cxf-swagger2-osgi-api/1.0.0
>   install -s mvn:de.kreeloo/cxf-swagger2-osgi-impl/1.0.0
>   
> It may happen that one component is complaining about a missing guava class even if you
provided it before. All you have todo is copy guava-18.jar into your deploy folder. I think
this is a karaf bug. I have to create a ticket for. After you place the guava file into your
deploy folder and type list, all bundles should be active.  
>   Now open your web browser and type: 
>   http://localhost:8181/cxf/swaggerSample/swagger.json
>   And all you see is the swagger header.
>   
>   I guess the problem is the ClasspathHelper.class from org.reflections it looks like
that this one is not able to access the osgi component. 
>   
>   The behavior is similar to this error description:
>   http://cxf.547215.n5.nabble.com/Swagger2Feature-via-blueprint-config-does-not-produce-the-expected-results-td5761841.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message