cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6909) Create an JCache based OAuthDataProvider
Date Thu, 19 May 2016 10:38:12 GMT

    [ https://issues.apache.org/jira/browse/CXF-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290874#comment-15290874
] 

Sergey Beryozkin commented on CXF-6909:
---------------------------------------

Thanks for this quality patch, looks good. Few comments:
- can you consider getting back to a Java 7 syntax ? We can keep it as is but that will mean
we will not be able to back-port it to CXF 3.1.x which is Java 7 based. I'm OK with this provider
be a new CXF 3.2.0 feature, but note 3.2.0 is still a long way from being considered for a
release, so it is up to you if you'd like to keep it on 3.2.0 or also merge to 3.1.x.

- can you please add an extension for saving authorization codes ? For ex, DefaultEhcacheOAuthDataProvider
and DefaultEhcacheCodeDataProvider, same for JPA. FYI, the reason 2 providers are there, one
for most of Oauth2, and another one only adding the code persistence is that originally I
thought that forcing developers to write the code persistence in cases where their servers
do not support the confidential web clients and the authorization code flow was not ideal.

- re 'Default'  in the class name. I did name 'Default'EhcacheOAuthDataProvider that way because
I thought, well, someone may prefer to implement Ehcache persistence some smarter way, etc,
but since then I named a JPA provider as simply JPAOAuthDataProvider/JPACodeDataProvider.
Likewise, please keep 'Default' if you'd like but  JCacheOAuthDataProvider would also be fine,
up to you too...

Thanks, Sergey
 

> Create an JCache based OAuthDataProvider
> ----------------------------------------
>
>                 Key: CXF-6909
>                 URL: https://issues.apache.org/jira/browse/CXF-6909
>             Project: CXF
>          Issue Type: New Feature
>            Reporter: Luca Burgazzoli
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message