cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6869) Consider adding Spring Boot starter
Date Fri, 27 May 2016 11:48:12 GMT

    [ https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303965#comment-15303965
] 

Sergey Beryozkin commented on CXF-6869:
---------------------------------------

Hi, 
thanks for the clarification, and in advance, for your patience :-).

So I did experiment with removing @JaxRsConfig from the CXF JAX-RS source - I feel that if
it is what blocks the AutoConfigure feature from being operational in JAX-RS cases then it
is reasonable to ask existing users to import it directly if needed - minor migration issue.
 
However it did not make any difference as far as loading the auto configuration feature is
concerned - it did not work when I updated the demo to start the application which imports
SpringComponentScanServer (which this time does not bring @JaxRsConfig any longer).  I'm a
bit confused right now :-)

FYI, I'm not sure having SpringComponentScanServer imported for JAX-RS auto configure by default
would work for all the users, there will be cases where they'd prefer to avoid the auto-discovery.

 I'd like to understand first why importing SpringComponentScanServer has side-effects as
far as having the auto-configuration applied. I wonder if it is an ordering issue: importing
SpringComponentScanServer starts a JAX-RS endpoint (in its jaxRsServer() bean) - if CXFServlet
has not been loaded by that time then an embedded CXF Jetty endpoint will be created. So may
be it can be enforced somehow, via a conditional annotation, that SpringComponentScanServer
is processed only after the auto-configuration, if any, has been applied...

Cheers, Sergey


> Consider adding Spring Boot starter
> -----------------------------------
>
>                 Key: CXF-6869
>                 URL: https://issues.apache.org/jira/browse/CXF-6869
>             Project: CXF
>          Issue Type: New Feature
>          Components: Integration
>            Reporter: Vedran Pavic
>            Assignee: Sergey Beryozkin
>
> I've recently authored a PR in Spring Boot to add support for auto-configuration of {{CXFServlet}}
and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling to add CXF
as a dependency to the project. Instead a 3rd party starter was suggested.
> The concept of a 3rd party starter is generally encouraged for technologies that don't
have first-class support in projects from Spring portfolio. Such 3rd party starters are listed
here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be easily expanded
to include JAX-RS support as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message