cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6869) Consider adding Spring Boot starter
Date Fri, 27 May 2016 09:18:13 GMT

    [ https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303802#comment-15303802
] 

Sergey Beryozkin commented on CXF-6869:
---------------------------------------

Hi Vedran
Np, thanks for finding the time.
 
I removed those dependencies because they were 'optional' and the auto configuration module
compiled OK without them  and jaxws and jaxrs starters do list them, I'm OK with bringing
them back, can you explain why it is important ?

SpringComponentScanServer helps with auto-discovering JAX-RS specific resources, but it is
not the only option, SampleRestApplication (currently disabled) imports JaxRsConfig directly
and at the moment I can switch the demo to use SampleRestApplication and remove JaxRsConfig.

I can also consider removing JaxRsConfig from the CXF JAX-RS code and document that uses working
with SpringComponentScanServer should import it directly, but I'm a bit concerned it might
affect some users as I know SpringComponentScanServer is being used.

So yes, please check if you can make Autoconfiguration 'prevail' even if some existing code
happens to import cxf.xml, I believe I've seen CXF JAX-WS code fragments targeted for SpringBoot
where it is imported too.

Thanks

> Consider adding Spring Boot starter
> -----------------------------------
>
>                 Key: CXF-6869
>                 URL: https://issues.apache.org/jira/browse/CXF-6869
>             Project: CXF
>          Issue Type: New Feature
>          Components: Integration
>            Reporter: Vedran Pavic
>            Assignee: Sergey Beryozkin
>
> I've recently authored a PR in Spring Boot to add support for auto-configuration of {{CXFServlet}}
and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling to add CXF
as a dependency to the project. Instead a 3rd party starter was suggested.
> The concept of a 3rd party starter is generally encouraged for technologies that don't
have first-class support in projects from Spring portfolio. Such 3rd party starters are listed
here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be easily expanded
to include JAX-RS support as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message