Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Mon, 4 Apr 2016 10:46:25 +0000 (UTC)
From: "Sergey Beryozkin (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.12952308.1458619209000.124591.1459766785661@Atlassian.JIRA>
In-Reply-To: <JIRA.12952308.1458619209000@Atlassian.JIRA>
References: <JIRA.12952308.1458619209000@Atlassian.JIRA>
 <JIRA.12952308.1458619209211@arcas>
Subject: [jira] [Commented] (CXF-6837) Add cache for
 MessageBodyReader/Writer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223930#comment-15223930 ] 

Sergey Beryozkin commented on CXF-6837:
---------------------------------------

Sure, I'll do it, but in meantime, lets talk about the patch.
Please recreate it against the trunk source, the current patch seems to have been created against the earlier version of the patch, so I do not see where the providers are added to the cache.

Next, I do not understand why we have the providers kept in 1) the cache and 2) in the factory ? If we have the cache, why do we still need to keep them in the factory itself ?
And if we have a cache, why does your code still check if the provider from the cache matches the media types and the type/generic types ?

Thanks, Sergey


> Add cache for MessageBodyReader/Writer
> --------------------------------------
>
>                 Key: CXF-6837
>                 URL: https://issues.apache.org/jira/browse/CXF-6837
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 3.1.5, 3.0.8
>         Environment: windows
>            Reporter: Neal Hu
>             Fix For: 3.2.0
>
>         Attachments: ProviderCache.java, ProviderFactory.patch
>
>
> CXF selects the msgBodyReader/writer in the reader/writer list for every request, which has big impact to the performance. Jersey also has the cache in org.glassfish.jersey.message.internal.MessageBodyFactory._getMessageBodyReader(...). I have tried add the cache for CXF in ProviderFactory and been proved that it has improved 7-8% for json requests in JMeter. Please let me know if you'd like me to add the enhancement for CXF. Thanks. 
> http://cxf.547215.n5.nabble.com/MessageBodyReader-Writer-cache-td5767091.html


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)