cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <>
Subject [jira] [Commented] (CXF-6837) Add cache for MessageBodyReader/Writer
Date Mon, 04 Apr 2016 10:46:25 GMT


Sergey Beryozkin commented on CXF-6837:

Sure, I'll do it, but in meantime, lets talk about the patch.
Please recreate it against the trunk source, the current patch seems to have been created
against the earlier version of the patch, so I do not see where the providers are added to
the cache.

Next, I do not understand why we have the providers kept in 1) the cache and 2) in the factory
? If we have the cache, why do we still need to keep them in the factory itself ?
And if we have a cache, why does your code still check if the provider from the cache matches
the media types and the type/generic types ?

Thanks, Sergey

> Add cache for MessageBodyReader/Writer
> --------------------------------------
>                 Key: CXF-6837
>                 URL:
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 3.1.5, 3.0.8
>         Environment: windows
>            Reporter: Neal Hu
>             Fix For: 3.2.0
>         Attachments:, ProviderFactory.patch
> CXF selects the msgBodyReader/writer in the reader/writer list for every request, which
has big impact to the performance. Jersey also has the cache in org.glassfish.jersey.message.internal.MessageBodyFactory._getMessageBodyReader(...).
I have tried add the cache for CXF in ProviderFactory and been proved that it has improved
7-8% for json requests in JMeter. Please let me know if you'd like me to add the enhancement
for CXF. Thanks. 

This message was sent by Atlassian JIRA

View raw message