Return-Path: X-Original-To: apmail-cxf-issues-archive@www.apache.org Delivered-To: apmail-cxf-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8AD7D18F88 for ; Thu, 10 Mar 2016 10:05:41 +0000 (UTC) Received: (qmail 94853 invoked by uid 500); 10 Mar 2016 10:05:41 -0000 Delivered-To: apmail-cxf-issues-archive@cxf.apache.org Received: (qmail 94782 invoked by uid 500); 10 Mar 2016 10:05:41 -0000 Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list issues@cxf.apache.org Received: (qmail 94754 invoked by uid 99); 10 Mar 2016 10:05:41 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2016 10:05:41 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C389B2C1F60 for ; Thu, 10 Mar 2016 10:05:40 +0000 (UTC) Date: Thu, 10 Mar 2016 10:05:40 +0000 (UTC) From: "Alessio Soldano (JIRA)" To: issues@cxf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CXF-6826) Cache MediaTypeHeaderProvider.valueOf(String mType) results MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CXF-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188998#comment-15188998 ] Alessio Soldano commented on CXF-6826: -------------------------------------- Thanks for the feedback Sergey. Two comments: 1) the idea of having a non-static map could be good, but the MediaTypeHeaderProvider is statically accessed from the JAXRSUtils (for instance I've seen it being heavily invoked from ProviderFactory.matchesWriterCriterias(...) -> JAXRSUtils.getProviderProduceTypes(MessageBodyWriter provider), it doesn't seem to me the RuntimeDelegateImpl is involved in that case 2) wiping out the concurrent map after it reaches a given size should be easy (but unfair, I'd say), evicting stuff from a deque or use a circular buffer would have the drawback of slowing the get, right? > Cache MediaTypeHeaderProvider.valueOf(String mType) results > ----------------------------------------------------------- > > Key: CXF-6826 > URL: https://issues.apache.org/jira/browse/CXF-6826 > Project: CXF > Issue Type: Improvement > Components: JAX-RS > Reporter: Alessio Soldano > > MediaTypeHeaderProvider.valueOf(String mType) ends up being called a lot with the same parameter values, as those are basically the contents of the @Produce annotations on resources. Each request ends up into the same invocation, which is cpu and memory intensive. > It might make sense to add a map in the MediaTypeHeaderProvider to store the result of the static valueOf method invocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)