cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6729) Version 1 NewCookie is not compliant with RFC 2109
Date Tue, 12 Jan 2016 11:42:39 GMT

    [ https://issues.apache.org/jira/browse/CXF-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093775#comment-15093775
] 

Sergey Beryozkin commented on CXF-6729:
---------------------------------------

Hi Neal

I meant the value field, but please ignore my comment, maybeQuote() does check for null, and
it won't harm even if a value filed will be checked again, so it is OK.
Simply keep the original code (note it also prints Version in the end) and add maybeQuote()
there, and if you prefer update the maxAge check as in your code.
So we need to unquote if needed in NewCookie.fromString(). 

I guess the same, quote/unquote should be done with Cookie to/from String - we can deal with
it in another JIRA may be

Sergey 

>  Version 1 NewCookie is not compliant with RFC 2109
> ---------------------------------------------------
>
>                 Key: CXF-6729
>                 URL: https://issues.apache.org/jira/browse/CXF-6729
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.0.7, 3.1.4
>         Environment: Windows
>            Reporter: Neal Hu
>             Fix For: 3.1.5, 3.0.8
>
>         Attachments: NewCookieHeaderProvider.java, NewCookieHeaderProviderTest.java,
ResponseImplTest.java
>
>
> Hi,
> From http://www.ietf.org/rfc/rfc2109.txt and http://stackoverflow.com/questions/572482/why-do-cookie-values-with-whitespace-arrive-at-the-client-side-with-quotes
> the version 1 cookie look like: name="value with spaces";Max-Age=3600;Path="/";Version=1
> NewCookieHeaderProvider.toString(NewCookie) has not handled the special characters(RFC2068)
that need around with quotes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message