cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Freeman Fang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CXF-6704) Upgrade to httpclient 4.5.x
Date Tue, 15 Dec 2015 05:10:46 GMT

    [ https://issues.apache.org/jira/browse/CXF-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057352#comment-15057352
] 

Freeman Fang edited comment on CXF-6704 at 12/15/15 5:09 AM:
-------------------------------------------------------------

Hi Team,

If there's no other objection, I'm going to upgrade to httpcomponents.client 4.5.1, as it
also works with httpcomponents.core 4.4.x. This upgrade won't introduce any tests failure
BTW.

Sergey,
During my test for this upgrade, I saw JAXRSAsyncClientTest intermittent failure both with
httpcomponents.client 4.4.1(the current version) and 4.5.1, the below patch can fix it but
I'm not sure why it's intermittent failure or if there's something really wrong, so I will
leave this to you.
{code}
@@ -31,6 +31,7 @@ import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
 
 import javax.ws.rs.Consumes;
+import javax.ws.rs.NotAllowedException;
 import javax.ws.rs.NotFoundException;
 import javax.ws.rs.ProcessingException;
 import javax.ws.rs.WebApplicationException;
@@ -214,7 +215,7 @@ public class JAXRSAsyncClientTest extends AbstractBusClientServerTestBase
{
             future.get();
         } catch (Exception ex) {
             Throwable cause = ex.getCause();
-            assertTrue(cause instanceof ProcessingException);
+            assertTrue(cause instanceof NotAllowedException);
         }

{code}

Best Regards
Freeman


was (Author: ffang):
Hi Team,

If there's no other objection, I'm going to upgrade to httpcomponents.client 4.5.1, as it
also works with httpcomponents.core 4.4.x. This upgrade won't break any tests BTW.

Sergey,
During my test for this upgrade, I saw JAXRSAsyncClientTest intermittent failure both with
httpcomponents.client 4.4.1(the current version) and 4.5.1, the below patch can fix it but
I'm not sure why it's intermittent failure or if there's something really wrong, so I will
leave this to you.
{code}
@@ -31,6 +31,7 @@ import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
 
 import javax.ws.rs.Consumes;
+import javax.ws.rs.NotAllowedException;
 import javax.ws.rs.NotFoundException;
 import javax.ws.rs.ProcessingException;
 import javax.ws.rs.WebApplicationException;
@@ -214,7 +215,7 @@ public class JAXRSAsyncClientTest extends AbstractBusClientServerTestBase
{
             future.get();
         } catch (Exception ex) {
             Throwable cause = ex.getCause();
-            assertTrue(cause instanceof ProcessingException);
+            assertTrue(cause instanceof NotAllowedException);
         }

{code}

Best Regards
Freeman

> Upgrade to httpclient 4.5.x
> ---------------------------
>
>                 Key: CXF-6704
>                 URL: https://issues.apache.org/jira/browse/CXF-6704
>             Project: CXF
>          Issue Type: Wish
>          Components: Core
>    Affects Versions: 3.1.4
>            Reporter: Grzegorz Grzybek
>
> CXF 3.1.x uses httpclient 4.4.x which has a bug (HTTPCLIENT-1652) related to auth cache.
They switched to serialization when caching auth objects and a scenario with authenticated
proxy is now broken.
> It is fixed with httpclient 4.5.
> Is it ok to upgrade CXF to use httpclient 4.5.x?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message