cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colm O hEigeartaigh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6620) Fix DefaultSubjectProvider to support NameID formats other than “unspecified”
Date Mon, 05 Oct 2015 11:25:26 GMT

    [ https://issues.apache.org/jira/browse/CXF-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943249#comment-14943249
] 

Colm O hEigeartaigh commented on CXF-6620:
------------------------------------------


Could you submit a patch for this for CXF master? I think the best way to approach it is to
remove the default value of "unspecified" for the subjectNameIDFormat property. That way it
will pick up the correct NameID formats for the other principals. I'd like to leave the current
logic in there for X500Principals if the subjectNameIDFormat is set to "unspecified".

For CXF 3.0.x the default will remain for backwards compatibility reasons.

Colm.

> Fix DefaultSubjectProvider to support NameID formats other than “unspecified”
> -----------------------------------------------------------------------------
>
>                 Key: CXF-6620
>                 URL: https://issues.apache.org/jira/browse/CXF-6620
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 3.0.5, 3.1.2
>            Reporter: Armand Roelens
>            Assignee: Colm O hEigeartaigh
>         Attachments: CXF305DefaultSubjectProviderFix.png, CXF306-312DefaultSubjectProviderFix.png
>
>
> The DefaultSubjectProvider does not set “subjectNameIDFormat" to formats other than
unspecified. It needs to set the format correctly based on the type of principal. 
> Refer to the screenshots below that contain an example of a possible fix for CXF versions:
3.0.6-3.1.X and CXF versions: 3.0.5 and below respectively:
> Screenshot from CXF 3.0.5 and below: Shows code from getSubject()
> Screenshot from CXF 3.0.6 +: Shows code from createSubjectBean()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message