cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Beryozkin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6491) wadl2java produces incorrect Consumes annotation for multiple representations on POST methods
Date Wed, 15 Jul 2015 12:43:05 GMT

    [ https://issues.apache.org/jira/browse/CXF-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627990#comment-14627990
] 

Sergey Beryozkin commented on CXF-6491:
---------------------------------------

Well, it seems inconsistent with the idea of a method generated per representation, which
is what  'supportMultipleXmlReps' is for (as a side note I'll need to deprecate it and introduce
something like 'supportMultipleRepsWithElements' given that JSON reps can be checked too).
Also note it is unlikely you'd have a JSON rep linking to a schema element supported at the
code gen level outside of CXF...

Besides, when you have a proxy with two consumes, how would you decide what needs to be sent,
JSON or XML ? The option I suggested is a valid WADL, and IMHO easier to read. However, I
might consider adding a media type subtype as an additional method name qualifier to make
the method names unique in cases like yours...

 

> wadl2java produces incorrect Consumes annotation for multiple representations on POST
methods
> ---------------------------------------------------------------------------------------------
>
>                 Key: CXF-6491
>                 URL: https://issues.apache.org/jira/browse/CXF-6491
>             Project: CXF
>          Issue Type: Bug
>          Components: Tooling
>    Affects Versions: 3.0.2, 3.0.5, 3.1.1
>         Environment: CentOS 6.6, Java 
> java version "1.7.0_71"
> OpenJDK Runtime Environment (rhel-2.5.3.2.el6_6-x86_64 u71-b14)
> OpenJDK 64-Bit Server VM (build 24.65-b04, mixed mode)
>            Reporter: Pat Lynch
>            Assignee: Sergey Beryozkin
>             Fix For: 3.0.6, 3.1.2
>
>         Attachments: PlcmHohoResource.java, plcm-hoho-v2.xsd, plcm-hoho-v3.xsd, plcm-hoho.wadl,
plcm-hoho.xsd
>
>
> The wadl2java tool, with the supportMultipleXmlReps option, generates the wrong @Consumes
annotation values for each of the POST methods that have multiple representations.  The annotation
for all of the methods contains all of the media types instead of the single media type that
is appropriate for the specific method.
> I've tested the versions listed in the affected versions field, but it likely applies
to other versions as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message