cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CXF-6423) PrettyLoggingFilter tests and improvements
Date Tue, 02 Jun 2015 08:10:20 GMT

    [ https://issues.apache.org/jira/browse/CXF-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568744#comment-14568744
] 

ASF GitHub Bot commented on CXF-6423:
-------------------------------------

Github user skjolber commented on the pull request:

    https://github.com/apache/cxf/pull/75#issuecomment-107853240
  
    I see there were some changes done back in March which improved performance but altered
the behavior. 
    
    I seen now that what  is really necessary is to do the same thing in this module as the
core module. That means pretty-printing first than applying limit to truncate afterwards.
    
    I'll update the pull request.


> PrettyLoggingFilter tests and improvements
> ------------------------------------------
>
>                 Key: CXF-6423
>                 URL: https://issues.apache.org/jira/browse/CXF-6423
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Thomas SkjĂžlberg
>            Assignee: Christian Schneider
>            Priority: Minor
>
> Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
> 1. use a StringReader instead of getting bytes from a String and using an InputStream
(capture encoding issues at an eariler stage)
> 2. add parser exception handling based on whether the payload is truncated or not; return
original XML if deemed invalid
> 3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid
XML because some writers misbehave (are extra helpful) in a way unfit for logging. 
> 4.construct output StringWriter with a size based on the raw XML string size
> 5.additional test cases 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message