Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Date: Fri, 29 May 2015 13:55:17 +0000 (UTC)
From: "Petr Miko (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Message-ID: <JIRA.12833797.1432907659000.66558.1432907717142@Atlassian.JIRA>
In-Reply-To: <JIRA.12833797.1432907659000@Atlassian.JIRA>
References: <JIRA.12833797.1432907659000@Atlassian.JIRA>
 <JIRA.12833797.1432907659204@arcas>
Subject: [jira] [Created] (CXF-6427) Incorrect Response InputStream closing
 in AbstractClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Petr Miko created CXF-6427:
------------------------------

             Summary: Incorrect Response InputStream closing in AbstractClient
                 Key: CXF-6427
                 URL: https://issues.apache.org/jira/browse/CXF-6427
             Project: CXF
          Issue Type: Bug
    Affects Versions: 2.7.16
            Reporter: Petr Miko


In current implementation of AbstractClient is response body input stream closed in following method

{noformat}
    protected boolean responseStreamCanBeClosed(Message outMessage, Class<?> cls) {
        return cls != InputStream.class
            && MessageUtils.isTrue(outMessage.getContextualProperty("response.stream.auto.close"));
    } 
{noformat}
That means, that in case that if the response.stream.auto.close is not set to true, the input stream stays opened -> Socket is not free for reusing. 

In my opinion the proper implementation should be:
{noformat}
  protected boolean responseStreamCanBeClosed(Message outMessage, Class<?> cls) {
    return !cls.isAssignableFrom(InputStream.class) || MessageUtils.isTrue(outMessage.getContextualProperty("response.stream.auto.close"));
  }
{noformat}  
This way is the response body input stream:
* is closed even when the auto close property is not set (= default?) and cls is not a child of InputStream
* the input stream is not closed, if cls is child of InputStream class (do not know if there might be cases of its subclasses)

The current implementation is in my opinion incorrect, because in case of a lot quick/parallel requests over proxy clients we faced running out of Sockets - similarly to what is described in CXF-5144


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)