cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Skjølberg (JIRA) <j...@apache.org>
Subject [jira] [Updated] (CXF-6423) PrettyLoggingFilter tests and improvements
Date Wed, 27 May 2015 17:45:17 GMT

     [ https://issues.apache.org/jira/browse/CXF-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Skjølberg updated CXF-6423:
----------------------------------
    Description: 
Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
1. use a StringReader instead of getting bytes from a String and using an InputStream (capture
encoding issues at an eariler stage)
2. add parser exception handling based on whether the payload is truncated or not; return
original XML if deemed invalid
3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML
because some writers misbehave (are extra helpful) in a way unfit for logging. 
4.construct output StringWriter with a size based on the raw XML string size
5.additional test cases 


  was:
Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
1. use a StringReader instead of getting bytes from a String and using an InputStream (capture
encoding issues at an eariler stage)
2. add parser exception handling based on whether the payload is truncated or not; return
original XML if deemed invalid
3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML
because some writers misbehave. 
4.construct output StringWriter with a size based on the raw XML string size
5.additional test cases 



> PrettyLoggingFilter tests and improvements
> ------------------------------------------
>
>                 Key: CXF-6423
>                 URL: https://issues.apache.org/jira/browse/CXF-6423
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Thomas Skjølberg
>            Priority: Minor
>
> Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
> 1. use a StringReader instead of getting bytes from a String and using an InputStream
(capture encoding issues at an eariler stage)
> 2. add parser exception handling based on whether the payload is truncated or not; return
original XML if deemed invalid
> 3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid
XML because some writers misbehave (are extra helpful) in a way unfit for logging. 
> 4.construct output StringWriter with a size based on the raw XML string size
> 5.additional test cases 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message