cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Lohmann (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CXF-6379) Separate HTTP headers for multiple header values not possible - bug in CXF-3714 fix
Date Wed, 29 Apr 2015 16:34:06 GMT

     [ https://issues.apache.org/jira/browse/CXF-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Carsten Lohmann updated CXF-6379:
---------------------------------
    Description: 
In CXF-3714 a property has been introduced to allow multiple HTTP header values to be added
as separate headers.

But the corresponding fix in 
{{org.apache.cxf.transport.http.Headers#transferProtocolHeadersToURLConnection}} 
doesn't look correct. See 
https://fisheye6.atlassian.com/changelog/cxf?cs=6763178c36ae4392344f9e8e1ea3e714ba8a2520

To me it looks like it should be 
{code}
connection.addRequestProperty(header, s)
{code}
in {{transferProtocolHeadersToURLConnection()}}, instead of
{code}
connection.addRequestProperty(HttpHeaderHelper.COOKIE, s)
{code}.


  was:
In CXF-3714 a property has been introduced to allow multiple HTTP header values to be added
as separate headers.

But the corresponding fix in 
{{org.apache.cxf.transport.http.Headers#transferProtocolHeadersToURLConnection}} 
doesn't look correct. See 
https://fisheye6.atlassian.com/changelog/cxf?cs=6763178c36ae4392344f9e8e1ea3e714ba8a2520

It should be 
{code}
connection.addRequestProperty(header, s)
{code}
in {{transferProtocolHeadersToURLConnection()}}, instead of
{code}
connection.addRequestProperty(HttpHeaderHelper.COOKIE, s)
{code}.

And shouldn't the surrounding "if" also check for the "SET_COOKIE" header?
I stumbled upon this issue because I wanted to add multiple  "SET_COOKIE" headers - which
does not work.


> Separate HTTP headers for multiple header values not possible - bug in CXF-3714 fix
> -----------------------------------------------------------------------------------
>
>                 Key: CXF-6379
>                 URL: https://issues.apache.org/jira/browse/CXF-6379
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 3.0.4
>            Reporter: Carsten Lohmann
>
> In CXF-3714 a property has been introduced to allow multiple HTTP header values to be
added as separate headers.
> But the corresponding fix in 
> {{org.apache.cxf.transport.http.Headers#transferProtocolHeadersToURLConnection}} 
> doesn't look correct. See 
> https://fisheye6.atlassian.com/changelog/cxf?cs=6763178c36ae4392344f9e8e1ea3e714ba8a2520
> To me it looks like it should be 
> {code}
> connection.addRequestProperty(header, s)
> {code}
> in {{transferProtocolHeadersToURLConnection()}}, instead of
> {code}
> connection.addRequestProperty(HttpHeaderHelper.COOKIE, s)
> {code}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message